From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYuc5-0006PH-Ka for qemu-devel@nongnu.org; Mon, 07 Sep 2015 07:29:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYuc2-0001gt-G0 for qemu-devel@nongnu.org; Mon, 07 Sep 2015 07:29:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYuc2-0001gl-BO for qemu-devel@nongnu.org; Mon, 07 Sep 2015 07:29:26 -0400 References: <1440149685-14057-1-git-send-email-zhugh.fnst@cn.fujitsu.com> From: Paolo Bonzini Message-ID: <55ED7511.6020507@redhat.com> Date: Mon, 7 Sep 2015 13:29:21 +0200 MIME-Version: 1.0 In-Reply-To: <1440149685-14057-1-git-send-email-zhugh.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cpu: introduce CpuTopoInfo structure for argument simplification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Guihua , qemu-devel@nongnu.org, ehabkost@redhat.com, mst@redhat.com, afaerber@suse.de, imammedo@redhat.com Cc: Chen Fan On 21/08/2015 11:34, Zhu Guihua wrote: > @@ -107,14 +111,12 @@ static inline apic_id_t apicid_from_topo_ids(unsigned nr_cores, > static inline void x86_topo_ids_from_idx(unsigned nr_cores, > unsigned nr_threads, > unsigned cpu_index, > - unsigned *pkg_id, > - unsigned *core_id, > - unsigned *smt_id) > + X86CPUTopoInfo *topo) > { Isn't this function used in hw/i386/pc.c as well? Paolo