From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYxJK-0001L4-At for qemu-devel@nongnu.org; Mon, 07 Sep 2015 10:22:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYxJF-0007f4-ED for qemu-devel@nongnu.org; Mon, 07 Sep 2015 10:22:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:46789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYxJF-0007ez-92 for qemu-devel@nongnu.org; Mon, 07 Sep 2015 10:22:13 -0400 References: <1440149685-14057-1-git-send-email-zhugh.fnst@cn.fujitsu.com> <55ED7511.6020507@redhat.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <55ED9D92.5010506@suse.de> Date: Mon, 7 Sep 2015 16:22:10 +0200 MIME-Version: 1.0 In-Reply-To: <55ED7511.6020507@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] cpu: introduce CpuTopoInfo structure for argument simplification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Guihua , qemu-devel@nongnu.org, ehabkost@redhat.com Cc: Chen Fan , Paolo Bonzini , imammedo@redhat.com, mst@redhat.com Am 07.09.2015 um 13:29 schrieb Paolo Bonzini: > On 21/08/2015 11:34, Zhu Guihua wrote: >> @@ -107,14 +111,12 @@ static inline apic_id_t apicid_from_topo_ids(uns= igned nr_cores, >> static inline void x86_topo_ids_from_idx(unsigned nr_cores, >> unsigned nr_threads, >> unsigned cpu_index, >> - unsigned *pkg_id, >> - unsigned *core_id, >> - unsigned *smt_id) >> + X86CPUTopoInfo *topo) >> { >=20 > Isn't this function used in hw/i386/pc.c as well? In case it gets respun now, in Seattle I had asked Eduardo to update the subject with s/CpuTopoInfo/X86CPUTopoInfo/. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)