From: "Andreas Färber" <afaerber@suse.de>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qom/object.h: remove some child/parent doc
Date: Mon, 7 Sep 2015 17:46:51 +0200 [thread overview]
Message-ID: <55EDB16B.6080205@suse.de> (raw)
In-Reply-To: <1441400485-29167-1-git-send-email-marcandre.lureau@redhat.com>
Am 04.09.2015 um 23:01 schrieb marcandre.lureau@redhat.com:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> It looks like this documentation is obsolete: a child object may lookup
> its parent stored in the Object struct.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/qom/object.h | 3 ---
> 1 file changed, 3 deletions(-)
Either once again you are trying to do stuff behind my back, or your
setup is really broken: I double-checked that include/qom/ is listed in
MAINTAINERS, so I should've been CC'ed rather than just -trivial.
It's been a valid rule not to mess with these internal fields, therefore
this is not trivial at all, and that's one reason why my x86 CPU series
using it was an RFC. We should either come up with a proper wrapper
function object_get_parent(), or with a wrapper function adding a link<>
property (where we would need to be careful with ref counts) - long time
only the composition tree needed to mess with an object's parent.
If you have a concrete use case of parent access, please point to it.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-09-07 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 21:01 [Qemu-devel] [PATCH] qom/object.h: remove some child/parent doc marcandre.lureau
2015-09-04 21:25 ` Peter Crosthwaite
2015-09-04 21:42 ` Marc-André Lureau
2015-09-04 21:53 ` Peter Crosthwaite
2015-09-07 15:46 ` Andreas Färber [this message]
2015-09-11 10:13 ` Michael Tokarev
2015-09-11 11:14 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EDB16B.6080205@suse.de \
--to=afaerber@suse.de \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).