From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYz7v-0006LQ-KQ for qemu-devel@nongnu.org; Mon, 07 Sep 2015 12:18:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYz7s-0006ML-GD for qemu-devel@nongnu.org; Mon, 07 Sep 2015 12:18:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYz7s-0006Lr-CC for qemu-devel@nongnu.org; Mon, 07 Sep 2015 12:18:36 -0400 References: <1440553971-11108-1-git-send-email-arei.gonglei@huawei.com> From: Paolo Bonzini Message-ID: <55EDB8D8.4070602@redhat.com> Date: Mon, 7 Sep 2015 18:18:32 +0200 MIME-Version: 1.0 In-Reply-To: <1440553971-11108-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: peter.huangpeng@huawei.com On 26/08/2015 03:52, arei.gonglei@huawei.com wrote: > From: Gonglei > > vhost-scsi bootindex does't work because Qemu passes > wrong fireware path to seabios. > > before: > /pci@i0cf8/scsi@7channel@0/vhost-scsi@0,0 > after applying the patch: > /pci@i0cf8/scsi@7/channel@0/vhost-scsi@0,0 > > Reported-by: Subo > Signed-off-by: Gonglei > --- > hw/scsi/vhost-scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c > index 7eacca9..bac9ddb 100644 > --- a/hw/scsi/vhost-scsi.c > +++ b/hw/scsi/vhost-scsi.c > @@ -292,7 +292,7 @@ static char *vhost_scsi_get_fw_dev_path(FWPathProvider *p, BusState *bus, > { > VHostSCSI *s = VHOST_SCSI(dev); > /* format: channel@channel/vhost-scsi@target,lun */ > - return g_strdup_printf("channel@%x/%s@%x,%x", s->channel, > + return g_strdup_printf("/channel@%x/%s@%x,%x", s->channel, > qdev_fw_name(dev), s->target, s->lun); > } > > I was on vacation. :) Thanks, I applied this now. Paolo