qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4
Date: Mon, 07 Sep 2015 21:11:35 +0200	[thread overview]
Message-ID: <55EDE167.6050400@kamp.de> (raw)
In-Reply-To: <55EDBB21.1090400@redhat.com>

Am 07.09.2015 um 18:28 schrieb Paolo Bonzini:
>
> On 03/09/2015 15:11, Peter Lieven wrote:
>>>>>> edec47c main-loop: fix qemu_notify_event for aio_notify optimization
>>>>> Part of the above AioContext series.
>>>> So either the whole series or none of them I guess?
>>> It's a separate bug, and theoretically it's there in 2.3.1 as well, but
>>> no one ever reproduced it (it would hang in make check) so not
>>> worthwhile.
>> I maybe found another case where this bugfix seems to help. For various
>> reasons I'm still on 2.2.1 stable with some CVE fixes manually applied.
> Don't be ashamed to say that! :)
>
>> I currently work on the problem that a haning NFS Server where I mount
>> my CDROM ISOs from takes down the whole vServer because the main loop
>> hangs sooner or later.
>>
>> I already put some patches on the list which help to improve the situation:
>>
>> ide/atapi: make PIO read requests async
>> block/io: allow AIOCB without callback
>> ide/atapi: partially avoid deadlock if the storage backend is dead
>> block/nfs: cache allocated filesize for read-only files
>>
>> However, I ended up with one case where Qemu deadlocks in bdrv_drain_one.
>>
>> Scenario:
>>  - Windows 2012R2 with a random ISO mounted.
>>  - Block communication to NFS via Firewall
>>  - execute 'eject ide1-cd0' in the HMP
>>  - restore connectivity.
>>
>> The HMP hangs forever even if the NFS connectivity itself is restored.
> If that patch helps, it's not a problem to include it in other stable
> releases.

It helps, but I have a small issue when my backport of the patch
is applied.

I launch qemu witch a cmdline like this to probe for enforcable CPU types.

echo quit | qemu -enable-kvm -monitor stdio -nodefaults -nographic -cpu Haswell,enforce -S

Qemu hangs when entering the quit command. If I omit the -S it works. And without the
fix it also works with -S.

My backport (Linux only and without tests etc.) of the original fix is here:
https://github.com/plieven/qemu/commit/0ddcdc62a85f705017df16421d769e82b70f9b37

Maybe I made a mistake.

Peter

  reply	other threads:[~2015-09-07 19:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31  8:12 [Qemu-devel] Recent patches for 2.4 Peter Lieven
2015-07-31  8:22 ` Paolo Bonzini
2015-07-31  8:35   ` Peter Lieven
2015-07-31  9:29     ` Paolo Bonzini
2015-08-04  9:22       ` [Qemu-devel] [Qemu-stable] " Peter Lieven
2015-08-04 11:53         ` Paolo Bonzini
2015-08-04 11:57           ` Peter Lieven
2015-08-04 12:09             ` Paolo Bonzini
2015-08-04 12:29               ` Peter Lieven
2015-08-04 12:53                 ` Peter Lieven
2015-08-04 23:23                   ` ronnie sahlberg
2015-08-05  8:39                     ` Paolo Bonzini
2015-08-06  7:51                       ` Peter Lieven
2015-09-03 13:11       ` Peter Lieven
2015-09-07 16:28         ` Paolo Bonzini
2015-09-07 19:11           ` Peter Lieven [this message]
2015-09-07 19:14             ` Paolo Bonzini
2015-09-07 21:05               ` Peter Lieven
2015-09-21  7:40               ` Peter Lieven
2015-09-21  9:41                 ` Paolo Bonzini
2015-09-21  9:52                   ` Peter Lieven
2015-09-21 12:16                     ` Paolo Bonzini
2015-08-04 18:20     ` Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EDE167.6050400@kamp.de \
    --to=pl@kamp.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).