From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 11/13] qcow2: Support updating driver-specific options in reopen
Date: Mon, 7 Sep 2015 21:44:56 +0200 [thread overview]
Message-ID: <55EDE938.5070608@redhat.com> (raw)
In-Reply-To: <1441632381-26638-12-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On 07.09.2015 15:26, Kevin Wolf wrote:
> For updating the cache sizes or disabling lazy refcounts
And updating the cache clean timer, too.
> there is a bit
> more to do than just changing the variables, but otherwise we're all set
> for changing options during bdrv_reopen().
>
> Just implement the missing pieces and hook the functions up in
> bdrv_reopen().
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 72 insertions(+), 9 deletions(-)
Whether you mention it or not (can be fixed up when applying the patch,
too):
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-07 19:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 13:26 [Qemu-devel] [PATCH v3 00/13] qcow2: reopen: Change driver-specific runtime options Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 01/13] block: Allow specifying driver-specific options to reopen Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 02/13] qemu-io: Remove duplicate 'open' error message Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 03/13] qemu-io: Add command 'reopen' Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 04/13] qcow2: Improve error message Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 05/13] qcow2: Factor out qcow2_update_options() Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 06/13] qcow2: Move qcow2_update_options() call up Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 07/13] qcow2: Move rest of option handling to qcow2_update_options() Kevin Wolf
2015-09-07 19:35 ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 08/13] qcow2: Leave s unchanged on qcow2_update_options() failure Kevin Wolf
2015-09-07 19:38 ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 09/13] qcow2: Fix memory leak in qcow2_update_options() error path Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 10/13] qcow2: Make qcow2_update_options() suitable for transactions Kevin Wolf
2015-09-07 19:41 ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 11/13] qcow2: Support updating driver-specific options in reopen Kevin Wolf
2015-09-07 19:44 ` Max Reitz [this message]
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 12/13] qemu-iotests: Reopen qcow2 with lazy-refcounts change Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 13/13] qemu-iotests: More qcow2 reopen tests Kevin Wolf
2015-09-07 19:45 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EDE938.5070608@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).