From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZ2Lh-0000PP-8w for qemu-devel@nongnu.org; Mon, 07 Sep 2015 15:45:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZ2Lg-0003op-HA for qemu-devel@nongnu.org; Mon, 07 Sep 2015 15:45:05 -0400 References: <1441632381-26638-1-git-send-email-kwolf@redhat.com> <1441632381-26638-12-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <55EDE938.5070608@redhat.com> Date: Mon, 7 Sep 2015 21:44:56 +0200 MIME-Version: 1.0 In-Reply-To: <1441632381-26638-12-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rX09RAUi1Rk4HBu4TClLrnfwTp5tO9E95" Subject: Re: [Qemu-devel] [PATCH v3 11/13] qcow2: Support updating driver-specific options in reopen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rX09RAUi1Rk4HBu4TClLrnfwTp5tO9E95 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 07.09.2015 15:26, Kevin Wolf wrote: > For updating the cache sizes or disabling lazy refcounts And updating the cache clean timer, too. > there is a bit= > more to do than just changing the variables, but otherwise we're all se= t > for changing options during bdrv_reopen(). >=20 > Just implement the missing pieces and hook the functions up in > bdrv_reopen(). >=20 > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++++++= +------- > 1 file changed, 72 insertions(+), 9 deletions(-) Whether you mention it or not (can be fixed up when applying the patch, too): Reviewed-by: Max Reitz --rX09RAUi1Rk4HBu4TClLrnfwTp5tO9E95 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV7ek4AAoJEDuxQgLoOKytIDkH/jWxKRgybas3FLrmAaVINcdy 5B5EfDn2wwSggz776I1fpHc065JridxJ5oeDEvK9ljsVUddVfzad9h3IWMsgmvqX 2TbAxrbTVx7gw6IPk/m1qf63U5pYvcN3U11GYBfp0QyqikqggAATqu2g6Tlg0oCh YXNICJXYPWGriifDOLVioHF7OxZOVNR3zJtwPaCy3yuO82ojGzOTXY0QBSbbr1xW niUh6L2y+UCOdV7XOxCf3hm5UhlpU2LA49n4jwzBbCGxK23gfcg9Na/dHpBZMo8h G/pG+iBhfgFp556G+L4OdyYCjur8HUrA0YdKJmbvbK0VF9kiTyHMVF3lmGYYt70= =EMzc -----END PGP SIGNATURE----- --rX09RAUi1Rk4HBu4TClLrnfwTp5tO9E95--