From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42549)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZZ3Cg-0006xf-3x
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 16:39:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZZ3Cb-0000dQ-5k
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 16:39:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35855)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZZ3Cb-0000dM-19
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 16:39:45 -0400
References: <1440719744-24755-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1440719744-24755-4-git-send-email-mdroth@linux.vnet.ibm.com>
	<55ED6B7B.9060000@redhat.com> <20150907195547.10296.13210@loki>
	<20150907203723.10296.29727@loki>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55EDF60B.8000007@redhat.com>
Date: Mon, 7 Sep 2015 22:39:39 +0200
MIME-Version: 1.0
In-Reply-To: <20150907203723.10296.29727@loki>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, yhindin@redhat.com, leonid@daynix.com



On 07/09/2015 22:37, Michael Roth wrote:
> This kinda does it, although it introduces a circular dependency warning
> on posix (since qemu-ga$(EXESUF) == qemu-ga there, yet qemu-ga has
> a qemu-ga$(EXESUF) dependency.
> 
> Could be fixed by making a new 'qemu-guest-agent' do-the-right-thing target,
> but that means new build process for posix and w32 instead of just w32. The
> alternative is to only define the 'qemu-ga' do-the-right-thing target for w32
> (since posix already has such a target). That requires a Makefile ifdef MINGW
> or somesuch though, which isn't ideal. I think the latter is worth the
> simplified build process (same as we currently do on posix, but with some
> extra config params)

Or just "ifneq ($(EXESUF),)".

Paolo