From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZZBBN-0006iQ-9o
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 01:11:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZZBBK-0002RE-51
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 01:11:01 -0400
Received: from mail-pa0-f50.google.com ([209.85.220.50]:35632)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZZBBJ-00026I-PC
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 01:10:58 -0400
Received: by pacfv12 with SMTP id fv12so116161544pac.2
	for <qemu-devel@nongnu.org>; Mon, 07 Sep 2015 22:09:49 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1441216660-8717-1-git-send-email-rth@twiddle.net>
	<1441216660-8717-3-git-send-email-rth@twiddle.net>
	<CAFEAcA_x0m2vKcPGTqQnsnvTX8MzvAwV9kZSgpAm3X9uL010bA@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55EE6D9A.5080601@twiddle.net>
Date: Mon, 7 Sep 2015 22:09:46 -0700
MIME-Version: 1.0
In-Reply-To: <CAFEAcA_x0m2vKcPGTqQnsnvTX8MzvAwV9kZSgpAm3X9uL010bA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 02/11] target-arm: Introduce DisasCompare
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 09/07/2015 10:09 AM, Peter Maydell wrote:
> On 2 September 2015 at 18:57, Richard Henderson <rth@twiddle.net> wrote:
>> +    case 9: /* ls: !C || Z -> !(C && !Z) */
>> +        cond = TCG_COND_NE;
>> +        value = tcg_temp_new_i32();
>> +        global = false;
>> +        tcg_gen_neg_i32(value, cpu_CF);
>> +        tcg_gen_and_i32(value, value, cpu_ZF);
>>           break;
>
> The comment says hi is C && !Z, but the code
> doesn't seem to line up with that. At least part
> of that is presumably because we store ZF inverted,
> but why are we negating CF here?

We're computing CF ? -1 : 0.  ANDing that with !Z (aka cpu_ZF) gets us C & !Z.

>>       case 12: /* gt: !Z && N == V */
>>       case 13: /* le: Z || N != V */
>> +        cond = TCG_COND_NE;
>> +        value = tcg_temp_new_i32();
>> +        global = false;
>> +        tcg_gen_xor_i32(value, cpu_VF, cpu_NF);
>> +        tcg_gen_sari_i32(value, value, 31);
>> +        tcg_gen_andc_i32(value, cpu_ZF, value);
>
> I think this is correct, but it could use some commentary
> to explain what it's doing.

Fair enough.


r~