From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55023)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZZBDn-0007jG-Uy
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 01:13:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZZBDk-0003Vn-NA
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 01:13:31 -0400
Received: from mail-pa0-f47.google.com ([209.85.220.47]:32859)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZZBDk-0003Vg-Hf
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 01:13:28 -0400
Received: by pacex6 with SMTP id ex6so113567980pac.0
	for <qemu-devel@nongnu.org>; Mon, 07 Sep 2015 22:12:43 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1441216660-8717-1-git-send-email-rth@twiddle.net>
	<1441216660-8717-5-git-send-email-rth@twiddle.net>
	<CAFEAcA9ShVr92O4zSW1_59sqx8wUgbnmhwwjQeYC9NjE+Sd+nQ@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55EE6E48.3070806@twiddle.net>
Date: Mon, 7 Sep 2015 22:12:40 -0700
MIME-Version: 1.0
In-Reply-To: <CAFEAcA9ShVr92O4zSW1_59sqx8wUgbnmhwwjQeYC9NjE+Sd+nQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 04/11] target-arm: Use setcond and
	movcond for csel
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 09/07/2015 10:17 AM, Peter Maydell wrote:
>> +    c64->value = tcg_temp_new_i64();
>> +    c64->cond = c32.cond;
>> +    if (c32.cond == TCG_COND_EQ || c32.cond == TCG_COND_NE) {
>> +        tcg_gen_extu_i32_i64(c64->value, c32.value);
>> +    } else {
>> +        tcg_gen_ext_i32_i64(c64->value, c32.value);
>> +    }
>
> Signed extend would work for EQ and NE as well, wouldn't it?

Yes.

> Why prefer the unsigned extension in those cases? If there's
> a reason, it could do with being commented.

I dunno what I was really thinking there.


r~