From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZFJC-0003Ak-KF for qemu-devel@nongnu.org; Tue, 08 Sep 2015 05:35:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZFJ7-0003ny-M1 for qemu-devel@nongnu.org; Tue, 08 Sep 2015 05:35:22 -0400 Sender: Paolo Bonzini References: <1441704488-9512-1-git-send-email-berrange@redhat.com> From: Paolo Bonzini Message-ID: <55EEABD3.2090903@redhat.com> Date: Tue, 8 Sep 2015 11:35:15 +0200 MIME-Version: 1.0 In-Reply-To: <1441704488-9512-1-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH repost] gtk: avoid redefining _WIN32_WINNT macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , "qemu-trivial@nongnu.org" , Gerd Hoffmann , qemu-devel On 08/09/2015 11:28, Daniel P. Berrange wrote: > In file included from ui/gtk.c:40:0: > include/ui/gtk.h:5:0: warning: "_WIN32_WINNT" redefined > # define _WIN32_WINNT 0x0601 /* needed to get definition of MAPVK_VK_TO_VSC */ > ^ > In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/crtdefs.h:10:0, > from /usr/i686-w64-mingw32/sys-root/mingw/include/stdio.h:9, > from /home/berrange/src/virt/qemu/include/qemu/fprintf-fn.h:12, > from /home/berrange/src/virt/qemu/include/qemu-common.h:18, > from ui/gtk.c:37: > /usr/i686-w64-mingw32/sys-root/mingw/include/_mingw.h:225:0: note: this is the location of the previous definition > #define _WIN32_WINNT 0x502 > ^ > > Signed-off-by: Daniel P. Berrange > --- > include/ui/gtk.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/ui/gtk.h b/include/ui/gtk.h > index ee6dffd..7796231 100644 > --- a/include/ui/gtk.h > +++ b/include/ui/gtk.h > @@ -2,7 +2,9 @@ > #define UI_GTK_H > > #ifdef _WIN32 > -# define _WIN32_WINNT 0x0601 /* needed to get definition of MAPVK_VK_TO_VSC */ > +# ifndef _WIN32_WINNT > +# define _WIN32_WINNT 0x0601 /* needed to get definition of MAPVK_VK_TO_VSC */ > +# endif > #endif Your error message shows that _WIN32_WINNT was 0x0502, do you get MAPVK_VK_TO_VSC with this patch? Perhaps #undef the macro first, or do something like: #if !defined _WIN32_WINNT || _WIN32_WINNT < 0x0601 # undef _WIN32_WINNT # define _WIN32_WINNT 0x0601 #endif Paolo