From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZFc7-00031M-0w for qemu-devel@nongnu.org; Tue, 08 Sep 2015 05:54:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZFc3-0003lU-Pj for qemu-devel@nongnu.org; Tue, 08 Sep 2015 05:54:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZFc3-0003lO-L7 for qemu-devel@nongnu.org; Tue, 08 Sep 2015 05:54:51 -0400 References: <1441696197-22265-1-git-send-email-den@openvz.org> <1441696197-22265-3-git-send-email-den@openvz.org> From: Paolo Bonzini Message-ID: <55EEB066.5040304@redhat.com> Date: Tue, 8 Sep 2015 11:54:46 +0200 MIME-Version: 1.0 In-Reply-To: <1441696197-22265-3-git-send-email-den@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Peter Maydell , Luiz Capitulino , qemu-devel@nongnu.org, Pavel Butsykin On 08/09/2015 09:09, Denis V. Lunev wrote: > qemu-monitor-info.texi | 151 +++++++ This should be added in patch 4, not now. > +const MonitorDef *target_monitor_defs(void) __attribute__((weak)); > + > +const MonitorDef *target_monitor_defs(void) > +{ > + return NULL; > +} Weak symbols do not work on all platforms. Luckily, making libqemustub a static library gets exactly the same result without the need for weak symbols: the definition from the QEMU object files will hide the stub. You just need to remove __attribute__((weak)), and it should just work. Otherwise, the patches look good to me. Luiz, do you have time to post a pull request for v4, or do you want to pass HMP maintainership as well to someone else? Paolo