From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57022)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZZFuJ-0005WI-8v
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 06:13:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZZFuE-0003Va-71
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 06:13:43 -0400
Received: from relay.parallels.com ([195.214.232.42]:52115)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZZFuD-0003VI-VW
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 06:13:38 -0400
References: <1441699228-25767-1-git-send-email-den@openvz.org>
	<20150908092035.GG24489@ad.nay.redhat.com>
	<20150908101144.GB4230@noname.redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <55EEB4C6.5080207@openvz.org>
Date: Tue, 8 Sep 2015 13:13:26 +0300
MIME-Version: 1.0
In-Reply-To: <20150908101144.GB4230@noname.redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, "qemu-block@nongnu.org Raushaniya Maksudova" <rmaksudova@virtuozzo.com>

On 09/08/2015 01:11 PM, Kevin Wolf wrote:
> Am 08.09.2015 um 11:20 hat Fam Zheng geschrieben:
>> [Cc'ing qemu-block@nongnu.org]
>>
>> On Tue, 09/08 11:00, Denis V. Lunev wrote:
>>> To avoid such situation this patchset introduces patch per-drive option
>>> "disk-deadlines=on|off" which is unset by default.
>> The general idea sounds very nice. Thanks!
>>
>> Should we allow user configuration on the timeout?  If so, the option should be
>> something like "timeout-seconds=0,1,2...".  Also I think we could use werror
>> and rerror to control the handling policy (whether to ignore/report/stop on
>> timeout).
> Yes, I think the timeout needs to be configurable. However, the only
> action that makes sense is stop. Everything else would be unsafe because
> the running request could still complete at a later point.
>
> Another question I have related to safety is whether (and how) you can
> migrate away from a host that has been stopped because of a timeout. I
> guess migration needs to be blocked then?
>
> Kevin
this sounds reasonable. Noted for the next iteration.