From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZLcx-0003wj-PE for qemu-devel@nongnu.org; Tue, 08 Sep 2015 12:20:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZLct-00014Z-Ia for qemu-devel@nongnu.org; Tue, 08 Sep 2015 12:20:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZLct-00013t-BG for qemu-devel@nongnu.org; Tue, 08 Sep 2015 12:20:07 -0400 References: <1441699228-25767-1-git-send-email-den@openvz.org> <1441699228-25767-6-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <55EF0AB4.6090906@redhat.com> Date: Tue, 8 Sep 2015 10:20:04 -0600 MIME-Version: 1.0 In-Reply-To: <1441699228-25767-6-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DK7vJj6xUalRRUNftI665MgpccWm6agaR" Subject: Re: [Qemu-devel] [PATCH 5/5] disk_deadlines: add info disk-deadlines option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , Markus Armbruster , qemu-devel@nongnu.org, Raushaniya Maksudova , Luiz Capitulino , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DK7vJj6xUalRRUNftI665MgpccWm6agaR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/08/2015 02:00 AM, Denis V. Lunev wrote: > From: Raushaniya Maksudova >=20 > This patch adds "info disk-deadlines" qemu-monitor option that prints > dump of all disk requests which caused a disk deadline in Guest OS > from the very start of Virtual Machine: >=20 > disk_id type size total_time start_time > .-------------------------------------------------------- > ide0-hd1 FLUSH 0b 46.403s 22232930059574ns > ide0-hd1 FLUSH 0b 57.591s 22451499241285ns > ide0-hd1 FLUSH 0b 103.482s 22574100547397ns >=20 > Signed-off-by: Raushaniya Maksudova > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Kevin Wolf > CC: Markus Armbruster > CC: Luiz Capitulino > --- qapi interface review only: > +++ b/qapi-schema.json > @@ -3808,3 +3808,36 @@ > =20 > # Rocker ethernet network switch > { 'include': 'qapi/rocker.json' } > + > +## @DiskDeadlinesInfo > +# > +# Contains info about late requests which caused VM stopping > +# > +# @disk-id: name of disk (unique for each disk) Mark this with '#optional', and maybe describe why it would be missing. Does this correspond to the BDS node name where the deadline expired, in which case 'node' might be a nicer name than 'disk-id'? > +# > +# @type: type of request could be READ, WRITE or FLUSH Likewise for using #optional. Please make this an enum type, not an open-coded string. > +# > +# @size: size in bytes of the failed request? Should you also mention which offset the failed request started at? > +# > +# @total-time-ns: total time of request execution > +# > +# @start-time-ns: indicates the start of request execution > +# > +# Since: 2.5 > +## > +{ 'struct': 'DiskDeadlinesInfo', > + 'data' : { '*disk-id': 'str', > + '*type': 'str', > + 'size': 'uint64', > + 'total-time-ns': 'uint64', > + 'start-time-ns': 'uint64' } } > +## > +# @query-disk-deadlines: > +# > +# Returns information about last late disk requests. > +# > +# Returns: a list of @DiskDeadlinesInfo > +# > +# Since: 2.5 > +## > +{ 'command': 'query-disk-deadlines', 'returns': ['DiskDeadlinesInfo'] = } Should it be possible to filter to deadlines missed for a specific node, by having an arguments with an optional node name? Should any of the existing query-block or similar commands be modified to make it obvious that there are missed deadline stats, and that it would be useful to call query-disk-deadlines to learn more about them? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DK7vJj6xUalRRUNftI665MgpccWm6agaR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV7wq0AAoJEKeha0olJ0NqYs4H/juJqXPxY/BjQkmOSy5Ngxg8 +dFqkYlO09aa8QbZqNC757nmX/yikh0SWawg2BwpuOiYxvcIUQNO5bWgUMy65KcF I03zIoJEkw99p01Bj5x9HhZhNCeGNDBoFwsULqb+9MMtwTT4Jq5qG0XBDHCNQCBC th9YGi0NFHi3QusSgSavJCtKIKhVMW9hJPiZaPkAv4L9J+YcVOuLTWb0sZIJX8BZ mV10RyDSlMJS+hxO9GTuHZA4iTVFHnHiLJFCU81yv/57oelQU4/wEH6BYPZSTWiL NdqcaZg0PEYQwazsxK3KHibLNK5rPKYk+LT9UuVfiSQcSi4HTrP40wcnvzDoDjQ= =QtlP -----END PGP SIGNATURE----- --DK7vJj6xUalRRUNftI665MgpccWm6agaR--