From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53583)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZZOYq-0004Sw-80
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 15:28:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZZOYm-00044Z-6s
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 15:28:08 -0400
Received: from mail-qg0-x233.google.com ([2607:f8b0:400d:c04::233]:34124)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZZOYm-00044G-3T
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 15:28:04 -0400
Received: by qgez77 with SMTP id z77so92215865qge.1
	for <qemu-devel@nongnu.org>; Tue, 08 Sep 2015 12:28:03 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1441173123-25540-1-git-send-email-rth@twiddle.net>
	<CAFEAcA9kp_x82AU=EfgXuKFZ=cK2fStBXUKOTyUana5OSmWX6Q@mail.gmail.com>
	<55EF3069.3010802@twiddle.net>
	<CAFEAcA853DaZvwoK2Nvqq8styfkER=p20Qco2SUYjWyDeCAn1g@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55EF36C0.5080207@twiddle.net>
Date: Tue, 8 Sep 2015 12:28:00 -0700
MIME-Version: 1.0
In-Reply-To: <CAFEAcA853DaZvwoK2Nvqq8styfkER=p20Qco2SUYjWyDeCAn1g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Aurelien Jarno <aurelien@aurel32.net>, QEMU Developers <qemu-devel@nongnu.org>, dl.soluz@gmx.net, Artyom Tarasenko <atar4qemu@gmail.com>

On 09/08/2015 12:06 PM, Peter Maydell wrote:
> On 8 September 2015 at 20:00, Richard Henderson <rth@twiddle.net> wrote:
>> On 09/08/2015 11:56 AM, Peter Maydell wrote:
>>> My sparc test image (which is just the 32-bit debian from
>>> Aurelien's website) boots fine even with this patchset...
>>
>> Odd, it shouldn't.  ;-)
>>
>> Anyway, I've just fixed the sparc problem and re-pushed the tree to
>>
>>   git://github.com/rth7680/qemu.git tcg-search-2
>>
>> for anyone who wants to do any more testing.
> 
> ...so what was the bug? (Push doesn't seem to have made it
> to github yet.)

Err.. it has.  Tip should be 98cb3e2ecffd126177f43634b643be81bdc764e7.
So I guess you pulled it post fix?

The problem was in 12/20, "target-sparc: Remove gen_opc_jump_pc".

The original was slightly off in how it was computing the npc in a delay slot.
 The replacement keeps the dc->jump_pc array, but verifies that the value of
dc->jump_pc[1] is as expected: jump false to next insn.  It's a smaller change
to the translator, and easier to verify correctness.


r~