From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZPAc-0001J7-JW for qemu-devel@nongnu.org; Tue, 08 Sep 2015 16:07:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZPAX-0007OI-Ir for qemu-devel@nongnu.org; Tue, 08 Sep 2015 16:07:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZPAX-0007OC-Ac for qemu-devel@nongnu.org; Tue, 08 Sep 2015 16:07:05 -0400 References: <1441621003-2434-1-git-send-email-armbru@redhat.com> <1441621003-2434-31-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55EF3FE3.7050000@redhat.com> Date: Tue, 8 Sep 2015 14:06:59 -0600 MIME-Version: 1.0 In-Reply-To: <1441621003-2434-31-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5t6m9p47xCNE26IjlxpEi799x55LNoP5X" Subject: Re: [Qemu-devel] [PATCH RFC v5 30/32] qapi: New QMP command query-qmp-schema for QMP introspection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5t6m9p47xCNE26IjlxpEi799x55LNoP5X Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/07/2015 04:16 AM, Markus Armbruster wrote: > qapi/introspect.json defines the introspection schema. It's designed > for QMP introspection, but should do for similar uses, such as QGA. >=20 > The introspection schema does not reflect all the rules and > restrictions that apply to QAPI schemata. A valid QAPI schema has an > introspection value conforming to the introspection schema, but the > converse is not true. >=20 > Introspection lowers away a number of schema details, and makes > implicit things explicit: >=20 > +## > +# @SchemaInfoObjectMember > +# > +# An object member. > +# > +# @name: the member's name, as defined in the QAPI schema. > +# > +# @type: the name of the member's type. > +# > +# @default: #optional default when used as command parameter. > +# If absent, the parameter is mandatory. > +# If present, the value must be null. The parameter is > +# optional, and behavior when it's missing is not specified > +# here. > +# Future extension: if present and non-null, the parameter > +# is optional, and defaults to this value. > +# > +## > +# @SchemaInfoObjectVariant > +# > +# The variant members for a value of the type tag. > +# > +# @case: a value of the type tag. > +# > +# @type: the name of the object type that provides the variant members= > +# when the type tag has value @case. You aren't consistent on whether secondary lines describing the same @variable are indented or flush left. I don't care enough to hold up review, but just pointing it out in case you want to reflow some text. I've finished re-reading 31 and 32, and double-checking that the combined text of all three patches together makes sense as a whole. Looks like we're ready for this series to come out of RFC soon :) And I'll start rebasing and posting my followup patches that have already been on list... --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5t6m9p47xCNE26IjlxpEi799x55LNoP5X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV7z/jAAoJEKeha0olJ0NqKu4H/Awt/TgJAEyBoxmjjIpbzTm0 sTk7R283zRTc35kR6KLqpSp5nrYnby9riaxV38Le6J4jttEmYA6ae9OnhbTRG77h WnJ3pUY+JPxt0Svttzkf4x940EwXZsWYJTsIDA/wvsqvmz2qiQ0OQjkwDdIDVKI6 4v+0dSuBxfageFFdaiFixf/7D2l95oWZoBUAwXo6j2mPEv+zW7x188JB0cssaGgi /pR9ZL+yHjmMQjjMfq0P5i9zF9h6am7eE6SshMRze8Rfu2wwk3giqY/PlHJasE1Q ZUBrqwMzWRTPZocLOvJ9xFir8KfG6x8B/SPW5/gRZgYiGH8bNNm2WPgD1aE6014= =5GUv -----END PGP SIGNATURE----- --5t6m9p47xCNE26IjlxpEi799x55LNoP5X--