From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZPKP-0007xF-K9 for qemu-devel@nongnu.org; Tue, 08 Sep 2015 16:17:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZPKK-0004wW-Fu for qemu-devel@nongnu.org; Tue, 08 Sep 2015 16:17:13 -0400 References: <1441742995-11794-1-git-send-email-mreitz@redhat.com> <1441742995-11794-2-git-send-email-mreitz@redhat.com> From: Max Reitz Message-ID: <55EF423C.4010501@redhat.com> Date: Tue, 8 Sep 2015 22:17:00 +0200 MIME-Version: 1.0 In-Reply-To: <1441742995-11794-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5Pt0gKRAh7jVq4RXoBiUPufBViRPU7WNX" Subject: Re: [Qemu-devel] [PATCH 1/2] qcow2: Make size_to_clusters() return int64_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org, qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5Pt0gKRAh7jVq4RXoBiUPufBViRPU7WNX Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 08.09.2015 22:09, Max Reitz wrote: > Sadly, some images may have more clusters than what can be represented > using a plain int. We should be prepared for that case (in > qcow2_check_refcounts() we actually were trying to catch that case, but= > since size_to_clusters() truncated the returned value, that check never= > did anything useful). >=20 Cc: qemu-stable > Signed-off-by: Max Reitz > --- > block/qcow2-cluster.c | 20 +++++++++++--------- > block/qcow2.h | 2 +- > 2 files changed, 12 insertions(+), 10 deletions(-) --5Pt0gKRAh7jVq4RXoBiUPufBViRPU7WNX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV70I8AAoJEDuxQgLoOKyt5qwH/iY59MFSGt6i7DSaPZjGs/kU g/m6ZrM8N0ED4Yukw9W+ybu8M/SkxMBg8SHbNss0pppr0c5G7tCc4IlzzB88CZSu QqYYBcy6oH2IF4nHn98x+J1LF+lKR6gv0w41b5JT9z3j4+yCYjQsBAU87sxCOGyY s7EVqccyW170PavViJBi9EvgPrUzSkffJOu/3pI6WZBTLpHxk1m7CC1G07qxt+FZ Gu7y71gmUFYe0NJMVivP2l5hx5zjZhLpQY4W+ytjRDQDbQ3GOrbmMZo9NDLESan3 cKuPBjZ6Cm9WP9NEyJpSXk3QsZRSDNMwpLtZ4zgdL3Eeb/Lmccr8zgoI/gld52g= =hzHM -----END PGP SIGNATURE----- --5Pt0gKRAh7jVq4RXoBiUPufBViRPU7WNX--