From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZQLg-0006FQ-Jf for qemu-devel@nongnu.org; Tue, 08 Sep 2015 17:22:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZQLc-0003qX-Ld for qemu-devel@nongnu.org; Tue, 08 Sep 2015 17:22:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZQLc-0003q5-Eu for qemu-devel@nongnu.org; Tue, 08 Sep 2015 17:22:36 -0400 References: <1441697927-16456-1-git-send-email-yuanhan.liu@linux.intel.com> <1441697927-16456-7-git-send-email-yuanhan.liu@linux.intel.com> From: Eric Blake Message-ID: <55EF5196.3080802@redhat.com> Date: Tue, 8 Sep 2015 15:22:30 -0600 MIME-Version: 1.0 In-Reply-To: <1441697927-16456-7-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K67Ai8adb1j4iqsgAeXCDj6hIjdiOH7B1" Subject: Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuanhan Liu , qemu-devel@nongnu.org Cc: mst@redhat.com, changchun.ouyang@intel.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --K67Ai8adb1j4iqsgAeXCDj6hIjdiOH7B1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/08/2015 01:38 AM, Yuanhan Liu wrote: > From: Ouyang Changchun >=20 > This patch is initially based a patch from Nikolay Nikolaev. >=20 > Here is the latest version for adding vhost-user multiple queue support= , > by creating a nc and vhost_net pair for each queue. >=20 Reviewing grammar and interface only: > +++ b/docs/specs/vhost-user.txt > @@ -135,6 +135,19 @@ As older slaves don't support negotiating protocol= features, > a feature bit was dedicated for this purpose: > #define VHOST_USER_F_PROTOCOL_FEATURES 30 > =20 > +Multiple queue support > +------------------- > +Multiple queue is treated as a protocal extension, hence the slave has= to s/protocal/protocol/ > +implement protocol features first. Multiple queues is supported only w= hen > +the protocol feature VHOST_USER_PROTOCOL_F_MQ(bit 0) is set. > + > +The max # of queues the slave support can be queried with message s/#/number/ s/support/supports/ > +VHOST_USER_GET_PROTOCOL_FEATURES. Master should stop when the # of req= uested s/#/number/ > +queues is bigger than that. > + > +As all queues share one connection, the master use a unique index for = each s/use/uses/ > +queue in the sent message to identify one specified queue. > + > +++ b/qapi-schema.json > @@ -2480,12 +2480,16 @@ > # > # @vhostforce: #optional vhost on for non-MSIX virtio guests (default:= false). > # > +# @queues: #optional number of queues to be created for multiqueue vho= st-user > +# (default: 1) (Since 2.5) > +# > # Since 2.1 > ## > { 'struct': 'NetdevVhostUserOptions', > 'data': { > 'chardev': 'str', > - '*vhostforce': 'bool' } } > + '*vhostforce': 'bool', > + '*queues': 'int' } } Looks okay. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --K67Ai8adb1j4iqsgAeXCDj6hIjdiOH7B1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV71GWAAoJEKeha0olJ0NqNnsH/1QR6ER8cdFlw5h7/7DZTvYF GhykSLIERsfdB4PQDAkP6qQPEYVlPCNDHtWtd6UOVLcmdZOWvf8ZgmRYtQci/+vm qTL7ZdYhkxQxeZvcxqBaWZiF+yMWNR1m4wGEKNlnIeoTKiZLiBNsB7yRTBCASw1H NFLvfqQtU+bBAh9cEbwQhjhE1dTbj0H09+7Rzzqh9YEh1nBGwhuMCb9W1lSRnw8g wqxLhlcftAsoYspZgnmpletTgjkdGqMAbhZ+kHj4bqX82OeJLe5iIj/pIfoUdceB TBq5yJBd7oTaeynMHsmX69Mn2AUgrVQvL1Nl69Wd4AWc9cN66cKibvArFM8RSSY= =Zw3m -----END PGP SIGNATURE----- --K67Ai8adb1j4iqsgAeXCDj6hIjdiOH7B1--