From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 6/6] gtk: setlocale for LC_MESSAGES only
Date: Wed, 9 Sep 2015 11:48:21 +0200 [thread overview]
Message-ID: <55F00065.9020509@redhat.com> (raw)
In-Reply-To: <1441790938-29042-7-git-send-email-kraxel@redhat.com>
On 09/09/2015 11:28, Gerd Hoffmann wrote:
> Setting other LC_* affects printf behavior and breaks QMP.
> We don't have much beside menu item strings localized, so
> restrict the locale setting to LC_MESSAGES.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-stable@nongnu.org
> ---
> ui/gtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index a17b1d1..a0b2340 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -1950,7 +1950,7 @@ void gtk_display_init(DisplayState *ds, bool full_screen, bool grab_on_hover)
>
> s->free_scale = FALSE;
>
> - setlocale(LC_ALL, "");
> + setlocale(LC_MESSAGES, "");
> bindtextdomain("qemu", CONFIG_QEMU_LOCALEDIR);
> textdomain("qemu");
>
>
next prev parent reply other threads:[~2015-09-09 9:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 9:28 [Qemu-devel] [PATCH 0/6] gtk: tweak grab handling, misc fixes Gerd Hoffmann
2015-09-09 9:28 ` [Qemu-devel] [PATCH 1/6] gtk: check for existing grabs in gd_grab_{pointer, keyboard} Gerd Hoffmann
2015-09-09 14:46 ` Marc-André Lureau
2015-09-09 9:28 ` [Qemu-devel] [PATCH 2/6] gtk: move gd_update_caption calls to gd_{grab, ungrab}_{pointer, keyboard} Gerd Hoffmann
2015-09-09 14:47 ` Marc-André Lureau
2015-09-09 9:28 ` [Qemu-devel] [PATCH 3/6] gtk: trace input grab reason Gerd Hoffmann
2015-09-09 14:53 ` Marc-André Lureau
2015-09-09 9:28 ` [Qemu-devel] [PATCH 4/6] gtk: set free_scale when setting zoom_fit Gerd Hoffmann
2015-09-09 14:57 ` Marc-André Lureau
2015-09-09 9:28 ` [Qemu-devel] [PATCH 5/6] gtk: don't grab input when entering fullscreen Gerd Hoffmann
2015-09-09 15:01 ` Marc-André Lureau
2015-09-09 9:28 ` [Qemu-devel] [PATCH 6/6] gtk: setlocale for LC_MESSAGES only Gerd Hoffmann
2015-09-09 9:48 ` Paolo Bonzini [this message]
2015-09-09 15:14 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F00065.9020509@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).