From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZhaV-000656-Ga for qemu-devel@nongnu.org; Wed, 09 Sep 2015 11:47:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZhaS-0006Mi-Qh for qemu-devel@nongnu.org; Wed, 09 Sep 2015 11:47:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZhaS-0006Me-Kk for qemu-devel@nongnu.org; Wed, 09 Sep 2015 11:47:04 -0400 References: <93ffdfed7054529635e6acb935150d95dc173a12.1441627176.git.DirtY.iCE.hu@gmail.com> From: Eric Blake Message-ID: <55F05470.4050201@redhat.com> Date: Wed, 9 Sep 2015 09:46:56 -0600 MIME-Version: 1.0 In-Reply-To: <93ffdfed7054529635e6acb935150d95dc173a12.1441627176.git.DirtY.iCE.hu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UMgWDCqE4tLGtfj99aAjTmlbpvi4LuXO9" Subject: Re: [Qemu-devel] [PATCH 4/7] net: use Netdev instead of NetClientOptions in client init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Vincenzo Maffione , Stefan Hajnoczi , Giuseppe Lettieri , Luigi Rizzo This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UMgWDCqE4tLGtfj99aAjTmlbpvi4LuXO9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/07/2015 06:14 AM, K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n wrote: > This way we no longer need NetClientOptions and can convert Netdev > into a flat union. >=20 > Signed-off-by: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n > Reviewed-by: Eric Blake I may have reviewed this one, but I'm still not a fan of 3/7. Give me a chance to post my introspection followup patches that cherry-pick pieces of your work and make QMP netdev_add a full-fledged qapi-fied command; I'll keep you on cc when I post. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UMgWDCqE4tLGtfj99aAjTmlbpvi4LuXO9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV8FRwAAoJEKeha0olJ0NqLbgH/1jLm7KAoB10kjmVqMWBhxOZ KL4xdnXBU6QfeImjtgeza3HELTWl8h/lHwMYMwU6CNaQld1MKdYMPL0ngqd2Zw2F avHUUFGxnGX8bg/MfXmLnFV3eeWQ6MJJtcKOHqFDNbrxAAtgCH8eTtwQ5XHhaJoQ EkfQ9SXD28tmM8BK2oPkViykPU1RdG8bzSYPNNDZi59eqZCJRlPZKNJC8RqcTXDX Wv3SN8AEwDnlqqWXEziBDTJ5+71dxJg+A8oby2Ccg/kFv6RP4DB6M8eY6CohZtLG pcjQJJ/CCXEuk4QDL1xPptdzT/qNN78Mc/B1KlkmGk0ZpWnwRNPuKqWLy/uDMW0= =mhE6 -----END PGP SIGNATURE----- --UMgWDCqE4tLGtfj99aAjTmlbpvi4LuXO9--