From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38593)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1ZZy2U-0005NF-4B
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:21:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1ZZy2R-0005mx-1V
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:21:06 -0400
Received: from mga01.intel.com ([192.55.52.88]:40939)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1ZZy2Q-0005ms-SQ
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:21:02 -0400
References: <alpine.DEB.2.02.1509081818590.2672@kaball.uk.xensource.com>
	<CAFEAcA80p5jaGYstmXYH204OExVUm2Mn=qfxC3FeibzPNDi7Tw@mail.gmail.com>
	<alpine.DEB.2.02.1509091248460.2672@kaball.uk.xensource.com>
	<55F0D906.4070606@intel.com>
	<CAFEAcA-5TqR5a66arid1Axiaa2Xm3gQxXJFPeZ7gA778b-NEhQ@mail.gmail.com>
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Message-ID: <55F14B7B.2070706@intel.com>
Date: Thu, 10 Sep 2015 17:20:59 +0800
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-5TqR5a66arid1Axiaa2Xm3gQxXJFPeZ7gA778b-NEhQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "xen-devel@lists.xensource.com Devel" <xen-devel@lists.xensource.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

>> As you see this short log, "hw/pci-assign: split pci-assign.c", so this
>> means I just extract something from the original hw/i386/kvm/pci-assign.c,
>> and here so I just keep those original head files residing
>> hw/i386/kvm/pci-assign.c, and I didn't introduce anything new.
>
> hw/i386/kvm/pci-assign.c is only built if configure set CONFIG_KVM,
> which it won't do on Windows or OSX builds.
>
> It sounds like your patch has incorrectly moved code out of files
> which are compiled only if KVM is present, or only if we're doing
> Xen PCI passthrough, and into compiled-for-everything files.
>

Yes, we want to share this chunk of codes between Xen and Kvm. Just to 
this error, could we remove #include <sys/io.h>? As I mentioned I still 
can compile this file without this head file.

Thanks
Tiejun