From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42174)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1ZZyDQ-0005t6-M2
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:32:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1ZZyDM-00044Y-69
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:32:24 -0400
Received: from mga11.intel.com ([192.55.52.93]:14183)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1ZZyDM-00044N-13
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:32:20 -0400
References: <alpine.DEB.2.02.1509081818590.2672@kaball.uk.xensource.com>
	<CAFEAcA80p5jaGYstmXYH204OExVUm2Mn=qfxC3FeibzPNDi7Tw@mail.gmail.com>
	<alpine.DEB.2.02.1509091248460.2672@kaball.uk.xensource.com>
	<alpine.DEB.2.02.1509091706120.2672@kaball.uk.xensource.com>
	<55F0DB30.6070607@intel.com>
	<CAFEAcA9RM0Q0ZrhgZxYqRdYb+GTsd7QyZtNJGKqxOYse8vShfA@mail.gmail.com>
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Message-ID: <55F14E20.6070805@intel.com>
Date: Thu, 10 Sep 2015 17:32:16 +0800
MIME-Version: 1.0
In-Reply-To: <CAFEAcA9RM0Q0ZrhgZxYqRdYb+GTsd7QyZtNJGKqxOYse8vShfA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "xen-devel@lists.xensource.com Devel" <xen-devel@lists.xensource.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

> xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH
> was set by configure. That won't be the case on OSX or Windows, where
> the Xen headers don't exist.
>

Okay. This actually shouldn't be enabled on Windows so what about this?

diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 58a33fb..9a1fcb9 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -739,6 +739,7 @@ static const TypeInfo i440fx_info = {
      .class_init    = i440fx_class_init,
  };

+#ifndef _WIN32
  /* IGD Passthrough Host Bridge. */
  typedef struct {
      uint8_t offset;
@@ -819,6 +820,7 @@ static const TypeInfo igd_passthrough_i440fx_info = {
      .instance_size = sizeof(PCII440FXState),
      .class_init    = igd_passthrough_i440fx_class_init,
  };
+#endif

  static const char *i440fx_pcihost_root_bus_path(PCIHostState *host_bridge,
                                                  PCIBus *rootbus)
@@ -861,7 +863,9 @@ static const TypeInfo i440fx_pcihost_info = {
  static void i440fx_register_types(void)
  {
      type_register_static(&i440fx_info);
+#ifndef _WIN32
      type_register_static(&igd_passthrough_i440fx_info);
+#endif
      type_register_static(&piix3_pci_type_info);
      type_register_static(&piix3_info);
      type_register_static(&piix3_xen_info);

Thanks
Tiejun