From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZyLV-0007pc-AW for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:40:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZyLS-0000EJ-4E for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:40:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZyLR-0000E7-Kr for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:40:42 -0400 References: <1441816441-7730-1-git-send-email-pbonzini@redhat.com> <1441816441-7730-3-git-send-email-pbonzini@redhat.com> <20150910103319-mutt-send-email-mst@redhat.com> <55F14B34.5050906@redhat.com> <20150910122258-mutt-send-email-mst@redhat.com> <55F14D23.6090906@redhat.com> <20150910123113-mutt-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <55F15015.2040700@redhat.com> Date: Thu, 10 Sep 2015 11:40:37 +0200 MIME-Version: 1.0 In-Reply-To: <20150910123113-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: cornelia.huck@de.ibm.com, den@openvz.org, qemu-devel@nongnu.org On 10/09/2015 11:32, Michael S. Tsirkin wrote: > > kvm.c keeps it consistent between target-i386/kvm.c and > > target-i386/cpu.h (which will include standard-headers/asm-x86/hyperv.h > > in Denis's patch). > > Yes but kvm_para.h uses asm/hyperv.h > MAybe do the same everywhere? Unfortunately you cannot use asm/hyperv.h in target-i386/cpu.h, because Win32 builds do not have -Ilinux-headers. That's the reason why I needed to move it to standard-headers. :( Paolo > Seems marginally prettier, but you decide, I'm not interested > in pushing this point.