From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Za4bM-0007r1-Uz
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 12:21:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Za4bH-0007gu-D1
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 12:21:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41110)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Za4bH-0007gm-7W
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 12:21:27 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id A90E3C0B987B
	for <qemu-devel@nongnu.org>; Thu, 10 Sep 2015 16:21:26 +0000 (UTC)
References: <1441891948-28169-1-git-send-email-armbru@redhat.com>
	<1441891948-28169-8-git-send-email-armbru@redhat.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55F1AE00.8010608@redhat.com>
Date: Thu, 10 Sep 2015 10:21:20 -0600
MIME-Version: 1.0
In-Reply-To: <1441891948-28169-8-git-send-email-armbru@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="OjempS3eaiR9lJTgHAb0DBN344P6TsUul"
Subject: Re: [Qemu-devel] [PULL 7/7] error: On abort,
 report where the error was created
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--OjempS3eaiR9lJTgHAb0DBN344P6TsUul
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/10/2015 07:32 AM, Markus Armbruster wrote:
> This is particularly useful when we abort in error_propagate(),
> because there the stack backtrace doesn't lead to where the error was
> created.  Looks like this:
>=20
>=20
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> ---

Already in mainline, but I'm wondering...


> +++ b/util/error.c
> @@ -18,12 +18,23 @@ struct Error
>  {
>      char *msg;
>      ErrorClass err_class;
> +    const char *src, *func;
> +    int line;
>  };
> =20

Should we also be modifying error_copy() to propagate source information
into the copy?

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--OjempS3eaiR9lJTgHAb0DBN344P6TsUul
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEbBAEBCAAGBQJV8a4AAAoJEKeha0olJ0NqG4gH+O2GNqhGLPcuXvUhKbslBFuF
/JV0HrDWVEOj3aXZRRvpEvLB9+tzPExClVgadWzZ3YG5k8eEl1KTstZ4fMn/8VfG
BmbgPBofHepugiQgLjr+7IZ2fyCuXZAD8jvMbciQIOVGnn/wbVE7P3lGC0/ssYpU
rJ2LC7C/80jNFI08EMy42QvP+xRkknzT3tTJlBjWJkGbJPkSBlVVfffgaub/Ls6k
+aGHWZkqiNOaQ5t+bb9FNol++EHm03OwUMiRkniKYQuI5CAb/RkjEOo/1GffkE2j
/AgYgMU8vuXa34qarB6eLDjAv25R0VEhJ3bpE6A4MqLht/UenpxYGI7mqkuiZg==
=LMhP
-----END PGP SIGNATURE-----

--OjempS3eaiR9lJTgHAb0DBN344P6TsUul--