From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47505)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Za4sC-0003rJ-OZ
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 12:38:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Za4s9-0002GD-Hy
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 12:38:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Za4s9-0002G6-Cp
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 12:38:53 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id E3E552F02AE
	for <qemu-devel@nongnu.org>; Thu, 10 Sep 2015 16:38:52 +0000 (UTC)
References: <1441891948-28169-1-git-send-email-armbru@redhat.com>
	<1441891948-28169-8-git-send-email-armbru@redhat.com>
	<55F1AE00.8010608@redhat.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55F1B217.9040606@redhat.com>
Date: Thu, 10 Sep 2015 10:38:47 -0600
MIME-Version: 1.0
In-Reply-To: <55F1AE00.8010608@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="Rfe3qXUxuGAO9DDcAMJrD7qADP0aPovjL"
Subject: Re: [Qemu-devel] [PULL 7/7] error: On abort,
 report where the error was created
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Rfe3qXUxuGAO9DDcAMJrD7qADP0aPovjL
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/10/2015 10:21 AM, Eric Blake wrote:

> Already in mainline, but I'm wondering...
>=20
>=20
>> +++ b/util/error.c
>> @@ -18,12 +18,23 @@ struct Error
>>  {
>>      char *msg;
>>      ErrorClass err_class;
>> +    const char *src, *func;
>> +    int line;
>>  };
>> =20
>=20
> Should we also be modifying error_copy() to propagate source informatio=
n
> into the copy?

Rather than just wondering, I've proposed a patch:
http://thread.gmane.org/gmane.comp.emulators.qemu/361110/focus=3D361117

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--Rfe3qXUxuGAO9DDcAMJrD7qADP0aPovjL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJV8bIXAAoJEKeha0olJ0NqhqwH/RzQ0DG7GhNIico+edjjXdIL
34NFQfm446QW6bt/D+yqIu0OKiD82c7VBYmG2JZ6BAvoTf1qzuziUj3jXKUsWEVd
e8w7uWiR3NfCfhlG8gKiLVwm4mPgsxJ1iGgF5e9livgZblq64lq79URVKL69y+6z
lKf3Bo16bDMM7xD/dVSuPX2V2kErWXZbhumZi5G5TFcPZk0dhA68F5ROHFxsaBZV
IFoJY6UfbFpO7gV9Yg4MnzEvNNtTWkFRqkirEB6bOA1BCPnUqXbjijbOusoro1Ny
BIU4uVq6vWwy2Rjh5XyIz9Skq6ks+pZtla53232YedMMg9LCiG3mvyb+/tfcDqU=
=hOzk
-----END PGP SIGNATURE-----

--Rfe3qXUxuGAO9DDcAMJrD7qADP0aPovjL--