From: Jeremy White <jwhite@codeweavers.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone project
Date: Thu, 10 Sep 2015 12:47:56 -0500 [thread overview]
Message-ID: <55F1C24C.1050101@codeweavers.com> (raw)
In-Reply-To: <1440934175-9971-1-git-send-email-marcandre.lureau@redhat.com>
On 08/30/2015 06:29 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> As previously discussed in the thread "libcacard: use the library?",
> make libcacard a standalone library and use it if --enable-smartcard.
>
> I made the following repo out of a qemu filter-branch and added autofoo
> build-sys: https://github.com/elmarco/libcacard. Since the original qemu
> git tags are there, I think the first release version should be v2.5,
> but there is no need to follow the same versions as qemu later on.
>
> libcacard could use the same infrastructure as the qemu project (mailing
> list, git server, reviews etc). I have some experience with libcacard,
> and I would be willing to maintain it, however I don't expect to do
> more development with it in the near future.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
I have reviewed this patch, and the new libcacard module. Modulo a few
minor nits (which Marc-André agreed to fix on irc), it all works well.
I think this is a sensible change and I'm willing to help with
libcacard maintenance, if we were to establish it as a project.
Reviewed-by: Jeremy White <jwhite@codeweavers.com>
Cheers,
Jeremy
> ---
> .gitignore | 1 -
> Makefile | 3 -
> Makefile.objs | 15 -
> configure | 51 +-
> docs/libcacard.txt | 483 ----------------
> hw/usb/Makefile.objs | 3 +-
> hw/usb/ccid-card-passthru.c | 2 +-
> libcacard/Makefile | 45 --
> libcacard/cac.c | 414 --------------
> libcacard/cac.h | 31 --
> libcacard/card_7816.c | 757 -------------------------
> libcacard/card_7816.h | 62 ---
> libcacard/card_7816t.h | 165 ------
> libcacard/event.c | 103 ----
> libcacard/eventt.h | 29 -
> libcacard/libcacard.pc.in | 13 -
> libcacard/libcacard.syms | 77 ---
> libcacard/link_test.c | 22 -
> libcacard/vcard.c | 325 -----------
> libcacard/vcard.h | 86 ---
> libcacard/vcard_emul.h | 66 ---
> libcacard/vcard_emul_nss.c | 1274 -------------------------------------------
> libcacard/vcard_emul_type.c | 57 --
> libcacard/vcard_emul_type.h | 32 --
> libcacard/vcardt.c | 40 --
> libcacard/vcardt.h | 59 --
> libcacard/vcardt_internal.h | 6 -
> libcacard/vevent.h | 27 -
> libcacard/vreader.c | 578 --------------------
> libcacard/vreader.h | 55 --
> libcacard/vreadert.h | 24 -
> libcacard/vscard_common.h | 178 ------
> libcacard/vscclient.c | 785 --------------------------
> 33 files changed, 19 insertions(+), 5849 deletions(-)
> delete mode 100644 docs/libcacard.txt
> delete mode 100644 libcacard/Makefile
> delete mode 100644 libcacard/cac.c
> delete mode 100644 libcacard/cac.h
> delete mode 100644 libcacard/card_7816.c
> delete mode 100644 libcacard/card_7816.h
> delete mode 100644 libcacard/card_7816t.h
> delete mode 100644 libcacard/event.c
> delete mode 100644 libcacard/eventt.h
> delete mode 100644 libcacard/libcacard.pc.in
> delete mode 100644 libcacard/libcacard.syms
> delete mode 100644 libcacard/link_test.c
> delete mode 100644 libcacard/vcard.c
> delete mode 100644 libcacard/vcard.h
> delete mode 100644 libcacard/vcard_emul.h
> delete mode 100644 libcacard/vcard_emul_nss.c
> delete mode 100644 libcacard/vcard_emul_type.c
> delete mode 100644 libcacard/vcard_emul_type.h
> delete mode 100644 libcacard/vcardt.c
> delete mode 100644 libcacard/vcardt.h
> delete mode 100644 libcacard/vcardt_internal.h
> delete mode 100644 libcacard/vevent.h
> delete mode 100644 libcacard/vreader.c
> delete mode 100644 libcacard/vreader.h
> delete mode 100644 libcacard/vreadert.h
> delete mode 100644 libcacard/vscard_common.h
> delete mode 100644 libcacard/vscclient.c
next prev parent reply other threads:[~2015-09-10 17:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 11:29 [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone project marcandre.lureau
2015-09-10 17:47 ` Jeremy White [this message]
2015-09-15 11:50 ` Marc-André Lureau
2015-09-15 13:28 ` Daniel P. Berrange
2015-09-15 13:37 ` Paolo Bonzini
2015-09-15 13:46 ` Daniel P. Berrange
2015-09-15 21:53 ` Dave Airlie
2015-09-16 6:29 ` Gerd Hoffmann
2015-09-15 13:40 ` Peter Maydell
2015-09-22 11:06 ` Paolo Bonzini
2015-09-22 11:25 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F1C24C.1050101@codeweavers.com \
--to=jwhite@codeweavers.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).