From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za7dn-0003Mo-6Z for qemu-devel@nongnu.org; Thu, 10 Sep 2015 15:36:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za7di-0001m7-1X for qemu-devel@nongnu.org; Thu, 10 Sep 2015 15:36:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za7dh-0001ll-SG for qemu-devel@nongnu.org; Thu, 10 Sep 2015 15:36:09 -0400 References: <1439386698-19980-1-git-send-email-pbonzini@redhat.com> <55F1ABF6.2030900@redhat.com> <55F1DA46.6000304@weilnetz.de> From: Paolo Bonzini Message-ID: <55F1DBA6.6060206@redhat.com> Date: Thu, 10 Sep 2015 21:36:06 +0200 MIME-Version: 1.0 In-Reply-To: <55F1DA46.6000304@weilnetz.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-thread: add a fast path to the Win32 QemuEvent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , qemu-devel@nongnu.org On 10/09/2015 21:30, Stefan Weil wrote: > The real time varies because the test includes user > interactions (pressing enter, starting test, > terminating QEMU after test). > > The user time (mainly emulation) does not vary much. > > The system time is significantly reduced (less than > 50 % in both runs with patch compared to both runs > without patch). Makes sense. You tested it better than I did. :) > I also had an (unrelated) crash with the unpatched code: > > wine: Unhandled page fault on read access to 0x0000004c at address > 0x43ed3d (thread 0009), starting debugger... > > It happened once in three runs, so this needs separate > investigations. > > Would you suggest additional tests? No, I think it's good. > I'll take your patch in my queue (git://qemu.weilnetz.de/qemu.git wxx). Thanks! Paolo