From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaItI-0001t0-PS for qemu-devel@nongnu.org; Fri, 11 Sep 2015 03:37:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaItF-0007Ck-Hd for qemu-devel@nongnu.org; Fri, 11 Sep 2015 03:37:00 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:32836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaItF-0007Cg-9P for qemu-devel@nongnu.org; Fri, 11 Sep 2015 03:36:57 -0400 Received: by wiclk2 with SMTP id lk2so53917317wic.0 for ; Fri, 11 Sep 2015 00:36:56 -0700 (PDT) Sender: Paolo Bonzini References: From: Paolo Bonzini Message-ID: <55F28497.90409@redhat.com> Date: Fri, 11 Sep 2015 09:36:55 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 14/15] cpu-common: Define tb_page_addr_t for everyone List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net On 11/09/2015 07:39, Peter Crosthwaite wrote: > So this is the same as in RFCv2 and the comment there was that it will not > work for linux-user mode WRT to qom/cpu.h fn prototypes needed this def. > But the solution there is instead to conditionalise the def of those hooks on > NEED_CPU_H. Then this patch is just needed for some misc. system-mode-only > core code usages. Sounds good, please squash that in this patch. Paolo