From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaNit-0007p0-GK for qemu-devel@nongnu.org; Fri, 11 Sep 2015 08:46:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaNis-00041m-Cg for qemu-devel@nongnu.org; Fri, 11 Sep 2015 08:46:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaNis-0003zT-7l for qemu-devel@nongnu.org; Fri, 11 Sep 2015 08:46:34 -0400 References: <1441974836-17476-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <55F2CD27.9000407@redhat.com> Date: Fri, 11 Sep 2015 06:46:31 -0600 MIME-Version: 1.0 In-Reply-To: <1441974836-17476-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ge0ddmBtjnC7ilLOmH9UrSlPWCWMXwoGJ" Subject: Re: [Qemu-devel] [PATCH v4] monitor: allow device_del to accept QOM paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Programmingkid , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ge0ddmBtjnC7ilLOmH9UrSlPWCWMXwoGJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/11/2015 06:33 AM, Daniel P. Berrange wrote: > Currently device_del requires that the client provide the > device short ID. device_add allows devices may be created > without giving an ID, at which point there is no way to > delete them with device_del. The QOM object path, however, > provides an alternative way to identify the devices. >=20 > Allowing device_del to accept an object path ensures all > devices are deletable regardless of whether they have an > ID. >=20 > (qemu) device_add usb-mouse > (qemu) qom-list /machine/peripheral-anon > device[0] (child) > type (string) > (qemu) device_del /machine/peripheral-anon/device[0] >=20 > Devices are required to be marked as hotpluggable > otherwise an error is raised >=20 > (qemu) device_del /machine/unattached/device[4] > Device 'PIIX3' does not support hotplugging >=20 > Signed-off-by: Daniel P. Berrange > --- Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ge0ddmBtjnC7ilLOmH9UrSlPWCWMXwoGJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV8s0oAAoJEKeha0olJ0Nq/ekIAJC0SotIjNSq68ohkoNa3opS GLdMLlWNzogadAs3h2+NwO5m5koTj49l4647ul2ZydMJHPlO39OjgIPKTeTUT0tw yKnJoeU4QRGxoIdGSqidHPgJjUq7+wMtczh9jUOCEw2INSkxAUG/HQxT8bei/MPQ pNCdBOgsgJhMnAHpw8F3/IViOLZ9RjuGjQK1s8JL8YLUCMzt4vNGdpw1d7Bw6mF3 MZhBgl0OGsxHZ+A0+slrOANArGOfkFg8OEf4dt51pipe7/gZw73xMNVbr6IB5oiG SqEHc4hDKJeVXPKNW+923RTPGgvc53PiXQM+YV3Bb8IqlKn4xGoiKSNIZ8CT3WY= =lPgd -----END PGP SIGNATURE----- --Ge0ddmBtjnC7ilLOmH9UrSlPWCWMXwoGJ--