From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaQ0m-0007Go-3C for qemu-devel@nongnu.org; Fri, 11 Sep 2015 11:13:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaQ0g-0007xb-3W for qemu-devel@nongnu.org; Fri, 11 Sep 2015 11:13:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaQ0f-0007xR-Tz for qemu-devel@nongnu.org; Fri, 11 Sep 2015 11:13:06 -0400 References: <1441983105-26376-1-git-send-email-armbru@redhat.com> <1441983105-26376-2-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55F2EF80.4010704@redhat.com> Date: Fri, 11 Sep 2015 09:13:04 -0600 MIME-Version: 1.0 In-Reply-To: <1441983105-26376-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cTqPIN5uxmdG5P98K4iKDgpoFX2tbXPTQ" Subject: Re: [Qemu-devel] [PATCH 1/4] error: New error_fatal List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, peter.crosthwaite@xilinx.com, hutao@cn.fujitsu.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cTqPIN5uxmdG5P98K4iKDgpoFX2tbXPTQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/11/2015 08:51 AM, Markus Armbruster wrote: > Similar to error_abort, but doesn't report where the error was > created, and terminates the process with exit(1) rather than abort(). >=20 > Signed-off-by: Markus Armbruster > --- > include/qapi/error.h | 11 +++++++++++ > util/error.c | 34 +++++++++++++++++++++------------- > 2 files changed, 32 insertions(+), 13 deletions(-) Reviewed-by: Eric Blake >=20 > diff --git a/include/qapi/error.h b/include/qapi/error.h > index d7878c3..c69dddb 100644 > --- a/include/qapi/error.h > +++ b/include/qapi/error.h > @@ -50,6 +50,9 @@ > * Call a function aborting on errors: > * foo(arg, &error_abort); > * > + * Call a function treating errors as fatal: > + * foo(arg, &error_fatal); > + * Might be worth a bit more explanatory text: error_abort is for diagnosing programmer errors (the situation cannot occur unless someone introduced a bug), while error_fatal is for gracefully diagnosing user errors at startup (the VM can't be booted because the user asked for the impossible). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cTqPIN5uxmdG5P98K4iKDgpoFX2tbXPTQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV8u+AAAoJEKeha0olJ0NqINYH/jdSS7qKN+6u1Atf0+94YWOc vSFfJZCtZFn/9HCRVlDLIRNge5Ues5TreGXvRzhz9R5C4SlQ6HqBNZxvNtTCZlBW tsxhA6UIttiyMKa3UrFdMJq+Z0NBYEC7UT8wCPnbkmu86DG31dly+sc21YXrv4gH ClZQGTm3danpy0aaEdbUt+/DkBeWlUP4RqReFRoDwb8JuZNlLnK0KKun4Oxvwmlp MviniS/AyJ+Bi8p+LpzsmANP5Z3mSnwJWoZhMR53Glitum2hI8XOkCdjdQbCoaeb oQtyWRTD2EQPi+pK22RnxNJl8nrniJkaU/k7X1DrEz2fJQW7/AhGDVU8FxzmBk0= =tJfb -----END PGP SIGNATURE----- --cTqPIN5uxmdG5P98K4iKDgpoFX2tbXPTQ--