From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaQHt-0002jo-FD for qemu-devel@nongnu.org; Fri, 11 Sep 2015 11:30:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaQHp-0000Lu-7G for qemu-devel@nongnu.org; Fri, 11 Sep 2015 11:30:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaQHp-0000Ll-0p for qemu-devel@nongnu.org; Fri, 11 Sep 2015 11:30:49 -0400 References: <7698893fc571c3b988dfff8470ea3edb75b0e593.1441667360.git.crosthwaite.peter@gmail.com> From: Eric Blake Message-ID: <55F2F3A7.7000602@redhat.com> Date: Fri, 11 Sep 2015 09:30:47 -0600 MIME-Version: 1.0 In-Reply-To: <7698893fc571c3b988dfff8470ea3edb75b0e593.1441667360.git.crosthwaite.peter@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="520WX5Q3nwv2MJPu8lQGOLnHNMpWr0bIU" Subject: Re: [Qemu-devel] [RFC PATCH v1 03/25] error: Factor out common error setter logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --520WX5Q3nwv2MJPu8lQGOLnHNMpWr0bIU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/10/2015 11:33 PM, Peter Crosthwaite wrote: > Currently set_error, set_error_errno, set_error_win32 do pretty much > the same thing with only a little bit of string manipulation in the > error code cases. Coreify that string manipulation as a callback and > factor out the bulk of the error_set fns to a common helper that calls > the callback at the right time. >=20 Commit 5523750 pretty much already does this. This patch can be dropped when rebasing the series to latest. > Signed-off-by: Peter Crosthwaite > --- >=20 > util/error.c | 81 +++++++++++++++++++++++++---------------------------= -------- > 1 file changed, 33 insertions(+), 48 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --520WX5Q3nwv2MJPu8lQGOLnHNMpWr0bIU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV8vOnAAoJEKeha0olJ0Nq3MEIAKOn8Obf5QF5ROv8N+2Daa+r IMCh8fAXfc1GEjMCEUvQO94TPQs6d/yKHNe2hCk3uCcn+2BPE7T3kvRXV1lOuHtb yyIajvc0HCCRLLi9uNpZfYUgO76dTzzzoLXl9VQo5YMUuEORIIIEwx0l8z1CQ0CZ l1I0wdH31qfUMc+UOBNxKPxCoKqCw+m/Tcd0VvWM6x4BIHsO+ADbc8T0Hru/C2OC XcaoAueULwNevw9cVpib6v+JWbucYEskn+7QnA1MbWHDlVFV37hSH3G0gXcJ/JBo EyM+X8NOmZVp0kZjC1Lh3RzN9+GiIYStzN7MZvMi1pGjkR7jAay+vzdIIFzS0z4= =roco -----END PGP SIGNATURE----- --520WX5Q3nwv2MJPu8lQGOLnHNMpWr0bIU--