From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH PULL 00/11] Extract TLS handling code from VNC server
Date: Fri, 11 Sep 2015 11:00:05 -0600 [thread overview]
Message-ID: <55F30895.4090402@redhat.com> (raw)
In-Reply-To: <20150911130919.GF21525@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On 09/11/2015 07:09 AM, Daniel P. Berrange wrote:
>> Apologies for not (re-)reviewing sooner, but I have comments on (at
>> least) patch 1, so I'm not sure this series should be merged just yet.
>
> Ok, please make sure you re-review this series, and not the earlier
> v6 posting, as a few things have been fixed here.
Okay, I've gone through the rest of the pull request, and nothing else
jumped out at me beyond patch 2, although it was superficial enough that
I'm not comfortable with re-adding R-b on the patches where you dropped
it. At this point, I'm trusting you as maintainer sending a valid
pullreq for your part of the tree.
I'm adding Markus in cc to make sure he is aware that your v2 pullreq
will affect introspection refactoring.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-09-11 17:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 12:10 [Qemu-devel] [PATCH PULL 00/11] Extract TLS handling code from VNC server Daniel P. Berrange
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 01/11] qapi: allow override of default enum prefix naming Daniel P. Berrange
2015-09-11 12:37 ` Eric Blake
2015-09-11 13:07 ` Daniel P. Berrange
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 02/11] tests: remove repetition in unit test object deps Daniel P. Berrange
2015-09-11 16:24 ` Eric Blake
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 03/11] crypto: move crypto objects out of libqemuutil.la Daniel P. Berrange
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 04/11] qom: allow QOM to be linked into tools binaries Daniel P. Berrange
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 05/11] crypto: introduce new base module for TLS credentials Daniel P. Berrange
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 06/11] crypto: introduce new module for TLS anonymous credentials Daniel P. Berrange
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 07/11] crypto: introduce new module for TLS x509 credentials Daniel P. Berrange
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 08/11] crypto: add sanity checking of " Daniel P. Berrange
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 09/11] crypto: introduce new module for handling TLS sessions Daniel P. Berrange
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 10/11] ui: fix return type for VNC I/O functions to be ssize_t Daniel P. Berrange
2015-09-11 12:10 ` [Qemu-devel] [PATCH PULL 11/11] ui: convert VNC server to use QCryptoTLSSession Daniel P. Berrange
2015-09-11 12:38 ` [Qemu-devel] [PATCH PULL 00/11] Extract TLS handling code from VNC server Eric Blake
2015-09-11 13:09 ` Daniel P. Berrange
2015-09-11 17:00 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F30895.4090402@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).