From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaUEx-0007ET-NI for qemu-devel@nongnu.org; Fri, 11 Sep 2015 15:44:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaUEQ-0006J8-Qd for qemu-devel@nongnu.org; Fri, 11 Sep 2015 15:43:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaUEQ-0006Ik-Kt for qemu-devel@nongnu.org; Fri, 11 Sep 2015 15:43:34 -0400 References: <1441611277-24596-1-git-send-email-famz@redhat.com> <1441611277-24596-5-git-send-email-famz@redhat.com> From: Eric Blake Message-ID: <55F32CE9.9060201@redhat.com> Date: Fri, 11 Sep 2015 13:35:05 -0600 MIME-Version: 1.0 In-Reply-To: <1441611277-24596-5-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QkFvrIct7pG6aSHoVrcgcDBeFxUnFqV6C" Subject: Re: [Qemu-devel] [PATCH v5 04/14] backup: Extract dirty bitmap handling as a separate function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Max Reitz , vsementsov@parallels.com, stefanha@redhat.com, John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QkFvrIct7pG6aSHoVrcgcDBeFxUnFqV6C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/07/2015 01:34 AM, Fam Zheng wrote: > This will be reused by the coming new transactional completion code. >=20 > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > block/backup.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) >=20 > diff --git a/block/backup.c b/block/backup.c > index 965654d..9776d9c 100644 > --- a/block/backup.c > +++ b/block/backup.c > @@ -210,6 +210,21 @@ static void backup_iostatus_reset(BlockJob *job) > =20 > bdrv_iostatus_reset(s->target); > } > +static void backup_cleanup_sync_bitmap(BackupBlockJob *job, int ret) Blank lines between functions? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QkFvrIct7pG6aSHoVrcgcDBeFxUnFqV6C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV8yzpAAoJEKeha0olJ0NqxNcIAJOr+XYgjHTcANTx3nNku//P rddxrATeGeshurzuA4Uu+KsBmrYJeVGH3TdMwynQcItQOpoKkcXiESIwBRlbG5ap SBd8mtFVwBKB/Q/qF1BuY+N0qtBUw2EhTeUznLRMzlxgN52hLZ+P/T6W3hZiv/Wh fFWaoFzd9B8X+btIExYtFOl5LpJQPVxP53V3B/p2P8OggnMddp0y/59j5ppKB+Np JMsLNB4zss4ccmlTfeaOpSAS2BGubgvtQhq5+SLBL66zIdgV2Bx75On6xvdfX/98 ETRBVDI0Q51ewH9yvLKyBPxIq3zO5hktlLdGyvWMaETclDZWL4gT/lyk8MVBzU4= =mqrS -----END PGP SIGNATURE----- --QkFvrIct7pG6aSHoVrcgcDBeFxUnFqV6C--