qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
	Max Reitz <mreitz@redhat.com>,
	vsementsov@parallels.com, stefanha@redhat.com,
	John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 09/14] block: Add block job transactions
Date: Fri, 11 Sep 2015 13:58:20 -0600	[thread overview]
Message-ID: <55F3325C.4090802@redhat.com> (raw)
In-Reply-To: <1441611277-24596-10-git-send-email-famz@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

On 09/07/2015 01:34 AM, Fam Zheng wrote:
> Sometimes block jobs must execute as a transaction group.  Finishing
> jobs wait until all other jobs are ready to complete successfully.
> Failure or cancellation of one job cancels the other jobs in the group.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> [Rewrite the implementation which is now contained in block_job_completed.
> --Fam]
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  blockjob.c               | 134 ++++++++++++++++++++++++++++++++++++++++++++++-
>  include/block/block.h    |   1 +
>  include/block/blockjob.h |  38 ++++++++++++++
>  3 files changed, 171 insertions(+), 2 deletions(-)

> +static void block_job_completed_txn_success(BlockJob *job)
> +{
> +    AioContext *ctx;
> +    BlockJobTxn *txn = job->txn;
> +    BlockJob *other_job, *next;
> +    /*
> +     * Successful completion, see if there are other running jobs in this
> +     * txn.
> +     **/

Unusual **/


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  parent reply	other threads:[~2015-09-11 19:58 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07  7:34 [Qemu-devel] [PATCH v5 00/14] block: incremental backup transactions using BlockJobTxn Fam Zheng
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 01/14] qapi: Add transaction support to block-dirty-bitmap operations Fam Zheng
2015-09-11 18:56   ` Eric Blake
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 02/14] iotests: add transactional incremental backup test Fam Zheng
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 03/14] block: rename BlkTransactionState and BdrvActionOps Fam Zheng
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 04/14] backup: Extract dirty bitmap handling as a separate function Fam Zheng
2015-09-11 18:26   ` Max Reitz
2015-09-11 19:35   ` Eric Blake
2015-09-15  5:00     ` Fam Zheng
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 05/14] blockjob: Introduce reference count Fam Zheng
2015-09-11 18:26   ` Max Reitz
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 06/14] blockjob: Add .commit and .abort block job actions Fam Zheng
2015-09-11 18:27   ` Max Reitz
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 07/14] blockjob: Add "completed" and "ret" in BlockJob Fam Zheng
2015-09-11 18:27   ` Max Reitz
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 08/14] blockjob: Simplify block_job_finish_sync Fam Zheng
2015-09-11 18:28   ` Max Reitz
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 09/14] block: Add block job transactions Fam Zheng
2015-09-11 18:34   ` Max Reitz
2015-09-11 18:52   ` Max Reitz
2015-09-15  5:02     ` Fam Zheng
2015-09-18 11:09     ` Max Reitz
2015-09-18 11:15       ` Max Reitz
2015-09-11 19:58   ` Eric Blake [this message]
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 10/14] blockdev: make BlockJobTxn available to qmp 'transaction' Fam Zheng
2015-09-11 18:38   ` Max Reitz
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 11/14] block/backup: support block job transactions Fam Zheng
2015-09-11 18:50   ` Max Reitz
2015-09-11 21:26   ` Eric Blake
2015-09-15  5:08     ` Fam Zheng
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 12/14] iotests: 124 - transactional failure test Fam Zheng
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 13/14] qmp-commands.hx: Update the supported 'transaction' operations Fam Zheng
2015-09-07  7:34 ` [Qemu-devel] [PATCH v5 14/14] tests: add BlockJobTxn unit test Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F3325C.4090802@redhat.com \
    --to=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).