From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zawem-0005OB-Si for qemu-devel@nongnu.org; Sat, 12 Sep 2015 22:04:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zawel-0001yq-RU for qemu-devel@nongnu.org; Sat, 12 Sep 2015 22:04:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zawel-0001yd-Me for qemu-devel@nongnu.org; Sat, 12 Sep 2015 22:04:39 -0400 References: <87io7j7j4y.fsf@blackfin.pond.sub.org> <55F0462D.8080709@suse.de> <87d1xr62ji.fsf@blackfin.pond.sub.org> <55F0587A.1070301@suse.de> <55F05B4C.9080708@redhat.com> From: Eric Blake Message-ID: <55F4D9B6.7020109@redhat.com> Date: Sat, 12 Sep 2015 20:04:38 -0600 MIME-Version: 1.0 In-Reply-To: <55F05B4C.9080708@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cD5XHu701vGxSH02VQ95eTsAeTCw1iCEK" Subject: Re: [Qemu-devel] Confused by QOM: /machine/unattached/device[5]/dr-connector[255]/fdt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Markus Armbruster Cc: qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cD5XHu701vGxSH02VQ95eTsAeTCw1iCEK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/09/2015 10:16 AM, Paolo Bonzini wrote: >>> Is returning NULL without setting an error okay? >>> >>> Should it return qnull() instead? Then the QMP return value would be= >>> JSON null. >=20 > JSON null support in QObject is new, it should be the result of > object_property_get_qobject() or even qmp_output_get_qobject(). Needs > auditing the code. Yes, returning QNull rather than NULL seems like the right approach. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cD5XHu701vGxSH02VQ95eTsAeTCw1iCEK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV9Nm2AAoJEKeha0olJ0NqCTMH/3agf77vQVt7wY66wKM0Kv4l ccp0f9H3Dqd3LGMPT+JbEU1a0pFm9Mibrvehkk8tbfPLt6bQ3QjIMyuygf8QnEEx T3A4uK/HIY8ep81K+pepT9z292aT7VDmj95jpJaxSPhr74l1EKdGsLvLyoeEODpT bwefWW9dePdKSF82bPYIB+WNI4Zzg+eUcPbf+5fjBefz8XBQvvNyuIndUwy9R2zo W2AoTTSZlHZze87oBTV6iLdDQbI3A3fqNFWPGlw0xryFDQBH7YuA17wyGmQOCHqF PL/X17oMV206qXf1Tc0BRyTA8DiDUV+DjdSk3381auaXIF3W+35MWHFSxS/q6qY= =bGD0 -----END PGP SIGNATURE----- --cD5XHu701vGxSH02VQ95eTsAeTCw1iCEK--