From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zb2XP-0004lq-MA for qemu-devel@nongnu.org; Sun, 13 Sep 2015 04:21:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zb2XL-0007nQ-7Q for qemu-devel@nongnu.org; Sun, 13 Sep 2015 04:21:27 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:39357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zb2XL-0007ml-0v for qemu-devel@nongnu.org; Sun, 13 Sep 2015 04:21:23 -0400 References: <1441239463-18981-1-git-send-email-rth@twiddle.net> <1441239463-18981-16-git-send-email-rth@twiddle.net> From: Bastian Koppelmann Message-ID: <55F531FB.8000108@mail.uni-paderborn.de> Date: Sun, 13 Sep 2015 10:21:15 +0200 MIME-Version: 1.0 In-Reply-To: <1441239463-18981-16-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 15/17] target-openrisc: Fix madd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, proljc@gmail.com On 09/03/2015 02:17 AM, Richard Henderson wrote: > Note that the specification for lf.madd.s is confused. It's > the only mention of supposed FPMADDHI/FPMADDLO special registers. > On the other hand, or1ksim implements a somewhat normal non-fused > multiply and add. Mirror that. > > Signed-off-by: Richard Henderson > --- > target-openrisc/cpu.h | 3 -- > target-openrisc/fpu_helper.c | 68 ++++++++++++++++---------------------------- > target-openrisc/helper.h | 7 ++--- > target-openrisc/translate.c | 13 +++------ > 4 files changed, 30 insertions(+), 61 deletions(-) > > Reviewed-by: Bastian Koppelmann Cheers, Bastian