From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"Chen, Tiejun" <tiejun.chen@intel.com>,
"xen-devel@lists.xensource.com Devel"
<xen-devel@lists.xensource.com>,
QEMU Developers <qemu-devel@nongnu.org>,
mst@redhat.com
Subject: Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
Date: Mon, 14 Sep 2015 11:57:44 +0200 [thread overview]
Message-ID: <55F69A18.20709@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1509101122570.2672@kaball.uk.xensource.com>
On 10/09/2015 12:29, Stefano Stabellini wrote:
> + if (lseek(config_fd, pos, SEEK_SET) != pos) {
> + return -errno;
> + }
> do {
> - rc = pread(config_fd, (uint8_t *)&val, len, pos);
> + rc = read(config_fd, (uint8_t *)&val, len);
> } while (rc < 0 && (errno == EINTR || errno == EAGAIN));
This leaks config_fd.
Paolo
next prev parent reply other threads:[~2015-09-14 9:57 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 17:21 [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 01/19] xen-hvm: Add trace to ioreq Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 02/19] i440fx: make types configurable at run-time Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 03/19] pc_init1: pass parameters just with types Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 04/19] piix: create host bridge to passthrough Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 05/19] hw/pci-assign: split pci-assign.c Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 06/19] xen, gfx passthrough: basic graphics passthrough support Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 07/19] xen, gfx passthrough: retrieve VGA BIOS to work Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 08/19] igd gfx passthrough: create a isa bridge Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 09/19] xen, gfx passthrough: register " Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 10/19] xen, gfx passthrough: register host bridge specific to passthrough Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 11/19] xen, gfx passthrough: add opregion mapping Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 12/19] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 13/19] xen/HVM: atomically access pointers in bufioreq handling Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 14/19] xen/pt: Update comments with proper function name Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 15/19] xen/pt: Make xen_pt_msi_set_enable static Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 16/19] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 17/19] xen: use errno instead of rc for xc_domain_add_to_physmap Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 18/19] xen/pt/msi: Add the register value when printing logging and error messages Stefano Stabellini
2015-09-08 17:21 ` [Qemu-devel] [PULL 19/19] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings Stefano Stabellini
2015-09-08 19:12 ` [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag Peter Maydell
2015-09-09 13:06 ` Stefano Stabellini
2015-09-09 16:10 ` Stefano Stabellini
2015-09-09 17:33 ` Peter Maydell
2015-09-10 1:21 ` Chen, Tiejun
2015-09-10 8:57 ` Peter Maydell
2015-09-10 9:32 ` Chen, Tiejun
2015-09-10 9:42 ` Stefano Stabellini
2015-09-10 10:29 ` Stefano Stabellini
2015-09-10 10:46 ` Michael S. Tsirkin
2015-09-10 11:26 ` Stefano Stabellini
2015-09-10 12:00 ` Michael S. Tsirkin
2015-09-10 12:00 ` Stefano Stabellini
2015-09-10 12:13 ` Michael S. Tsirkin
2015-09-11 0:40 ` Chen, Tiejun
2015-09-14 9:57 ` Paolo Bonzini [this message]
2015-09-15 9:55 ` Stefano Stabellini
2015-09-15 11:00 ` Paolo Bonzini
2015-09-16 1:11 ` Chen, Tiejun
2015-09-17 11:47 ` Stefano Stabellini
2015-09-09 17:21 ` Peter Maydell
2015-09-10 1:12 ` Chen, Tiejun
2015-09-10 8:59 ` Peter Maydell
2015-09-10 9:20 ` Chen, Tiejun
2015-09-10 9:59 ` Stefano Stabellini
2015-09-21 1:16 ` [Qemu-devel] [Xen-devel] " Chen, Tiejun
2015-09-21 16:03 ` Stefano Stabellini
2015-09-28 2:01 ` Chen, Tiejun
2015-09-28 10:01 ` Stefano Stabellini
2015-09-28 17:20 ` Pasi Kärkkäinen
2015-09-29 9:53 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F69A18.20709@redhat.com \
--to=pbonzini@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tiejun.chen@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).