Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector

[Paolo Bonzini <pbonzini@redhat.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 14/09/2015 13:45, David Gibson wrote:
>>> 
>>> === * There is no way for a child to determine what its parent
>>> is.  It is not * a bidirectional relationship.  This is by
>>> design. ===
>>> 
>>> This part always confused me as there is "Object *parent" in
>>> the "struct Object". So there is way to determine but it must
>>> not be used? Is it debug only?
>>> 
>>> Anyway, all members of the Object class are under /*< private
>>> >*/ so they should not be accesses in sPAPR code, I believe.
> Ah, good point, I missed that.  I guess we have to keep the owner 
> field, redundant though it seems.  Blech.

I think the comment is wrong or at least inaccurate; it only applies
to the external QOM interface.  The patch is a good idea, even though
OBJECT(x)->y traditionally is not used (instead you assign OBJECT(x) to
a different Object* variable).

Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJV9rmEAAoJEL/70l94x66DRYEH/3vWHTrKc5m3aoPgyxlSRCJf
dKWtYVhCJ4SFhhtW5v/XTB5ze6PWa8gg/Vv5hBUAhFAaoGkCx2jtLfP/+KS/oYT3
8x+JS9SpWQGjlsaIHGD91HenaOARafgsnJVNp4HqQPPz3IAfYP7noDNrVXhN4eQF
zjWnIVdfqD7nUW/f8zzVM3Xv7WEiV19K6foOUs/LTC6OEiqkOIAruvTqIAXn0MHe
bTeoWivfibO2Iomq6zExuNnSDjmqrdXuY4jmgMLzpzwrisczy2cCG0wbb0yzuK87
9UXtF90MNC/dIFMVrwmujruR2fWEvorIs+ZR+Udq2n5saau+4WUaX7ATOZzyVao=
=5cbm
-----END PGP SIGNATURE-----