From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 44/44] cutils: work around platform differences in strto{l, ul, ll, ull}
Date: Mon, 14 Sep 2015 17:00:02 +0200 [thread overview]
Message-ID: <55F6E0F2.8010800@redhat.com> (raw)
In-Reply-To: <CAFEAcA9Sb49UF8mnFYNexo910aR-Abz1n000FHtG5AvW=YVrdA@mail.gmail.com>
On 14/09/2015 16:48, Peter Maydell wrote:
>>> Windows returns 1 from strtoul and strtoull (instead of -1) for
>>> >> negative out-of-range input; fix it up.
> No problem with this patch, just wanted to say 'wat?' at this.
Indeed. I only tested with Wine, but it cannot be a mistake:
http://marc.info/?l=wine-patches&m=138011287312090&w=2
There are even test cases. :-)
Paolo
next prev parent reply other threads:[~2015-09-14 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 14:33 [Qemu-devel] [PULL v2 00/44] First batch of misc changes for 2.5 (2015-09-09) Paolo Bonzini
2015-09-14 14:33 ` [Qemu-devel] [PULL 44/44] cutils: work around platform differences in strto{l, ul, ll, ull} Paolo Bonzini
2015-09-14 14:47 ` Peter Maydell
2015-09-14 14:48 ` Peter Maydell
2015-09-14 15:00 ` Paolo Bonzini [this message]
2015-09-14 17:02 ` [Qemu-devel] [PULL v2 00/44] First batch of misc changes for 2.5 (2015-09-09) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F6E0F2.8010800@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).