From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbVEs-0002l5-40 for qemu-devel@nongnu.org; Mon, 14 Sep 2015 11:00:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbVEm-0000S3-8a for qemu-devel@nongnu.org; Mon, 14 Sep 2015 11:00:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbVEm-0000RO-4K for qemu-devel@nongnu.org; Mon, 14 Sep 2015 11:00:08 -0400 References: <1442241198-11235-1-git-send-email-pbonzini@redhat.com> <1442241198-11235-2-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <55F6E0F2.8010800@redhat.com> Date: Mon, 14 Sep 2015 17:00:02 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 44/44] cutils: work around platform differences in strto{l, ul, ll, ull} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 14/09/2015 16:48, Peter Maydell wrote: >>> Windows returns 1 from strtoul and strtoull (instead of -1) for >>> >> negative out-of-range input; fix it up. > No problem with this patch, just wanted to say 'wat?' at this. Indeed. I only tested with Wine, but it cannot be a mistake: http://marc.info/?l=3Dwine-patches&m=3D138011287312090&w=3D2 There are even test cases. :-) Paolo