From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbWod-00080P-EZ for qemu-devel@nongnu.org; Mon, 14 Sep 2015 12:41:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbWoY-0008LM-Sa for qemu-devel@nongnu.org; Mon, 14 Sep 2015 12:41:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbWoY-0008L9-HH for qemu-devel@nongnu.org; Mon, 14 Sep 2015 12:41:10 -0400 References: <1441974836-17476-1-git-send-email-berrange@redhat.com> <87lhc9m1ys.fsf@blackfin.pond.sub.org> <3FBFD05D-A0A4-4A2C-A235-39923ECA7FAE@gmail.com> From: Eric Blake Message-ID: <55F6F8A0.50800@redhat.com> Date: Mon, 14 Sep 2015 10:41:04 -0600 MIME-Version: 1.0 In-Reply-To: <3FBFD05D-A0A4-4A2C-A235-39923ECA7FAE@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="72JTAlfD0gMlX7TnXGmU7mhRCwcTX47Ir" Subject: Re: [Qemu-devel] [PATCH v4] monitor: allow device_del to accept QOM paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid , Markus Armbruster Cc: Paolo Bonzini , qemu-devel@nongnu.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --72JTAlfD0gMlX7TnXGmU7mhRCwcTX47Ir Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/14/2015 10:17 AM, Programmingkid wrote: >=20 > On Sep 14, 2015, at 11:53 AM, Markus Armbruster wrote: >=20 >> "Daniel P. Berrange" writes: >> >>> Currently device_del requires that the client provide the >>> device short ID. device_add allows devices may be created >> >> "allows devices to be created" >> >> Could perhaps be touched up on commit. >> >>> without giving an ID, at which point there is no way to >>> delete them with device_del. The QOM object path, however, >>> provides an alternative way to identify the devices. >>> >> If neither Andreas nor Paolo objects, I'd be willing to take this >> through my tree. >=20 > If you do accept this patch, would you still be willing to > accept an auto-generated ID patch still? The two are orthogonal. Deleting by QOM path is useful even if all devices are given an id, and auto-generating an id may be useful to human users (even though libvirt won't rely on it) regardless of whether deleting devices by QOM path is in the tree. But you are worrying about nothing; although Kevin is waiting for a v3, he has already mentioned on v2 that he is ready to queue auto-generation once it works: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00877.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --72JTAlfD0gMlX7TnXGmU7mhRCwcTX47Ir Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV9vigAAoJEKeha0olJ0NqLCYH/3RiRlFGObI9dB+b31XS1ZQ9 sVK6ate8ej6GrzlLQ8gM2rmrwjjUJIpAsD1buR6aHhgTARHcHWOJTVuUdiqCLYWx r5D2k/0xK7B1gP/m/2WzSexFMluuLp+r9Tosq3f7ivfMX/s0FqE6GVLznw6iHUpV 0Uf7AWqCgZ7R0NUa4xY2SlBTDq8FS+mVVZrWbtEh6qOztkBfoakXsTxSqcLdhCh3 H0XAIL2e1XTggQkrgzfOpo4ZSJ0mX0CXhbOXFyn/SFqrmK7y6/rtJKYv7eoDqc6H TPAOCENdLcDFgcFEF+/tNS5abFHvMsdsqG51+DqRGjOpubEbWB8aSzvgxDdACQ4= =0Ubg -----END PGP SIGNATURE----- --72JTAlfD0gMlX7TnXGmU7mhRCwcTX47Ir--