* Re: [Qemu-devel] [PATCH] linux-user/signal.c: Fix several issues for target alpha [not found] <1442114116-6146-1-git-send-email-gang.chen.5i5j@gmail.com> @ 2015-09-14 17:13 ` Richard Henderson 2015-09-14 18:35 ` Chen Gang 0 siblings, 1 reply; 2+ messages in thread From: Richard Henderson @ 2015-09-14 17:13 UTC (permalink / raw) To: gang.chen.5i5j, riku.voipio, peter.maydell; +Cc: qemu-devel, xili_gchen_5257 On 09/12/2015 08:15 PM, gang.chen.5i5j@gmail.com wrote: > env->ir[IR_RA] = r26; > env->ir[IR_PV] = env->pc = ka->_sa_handler; > env->ir[IR_A0] = sig; > env->ir[IR_A1] = 0; > env->ir[IR_A2] = frame_addr + offsetof(struct target_sigframe, sc); > env->ir[IR_SP] = frame_addr; > + > +give_sigsegv: > + if (sig == TARGET_SIGSEGV) { > + ka->_sa_handler = TARGET_SIG_DFL; > + } > + force_sig(TARGET_SIGSEGV); > } Fallthrough into the sigsegv handler? That's clearly wrong. r~ ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user/signal.c: Fix several issues for target alpha 2015-09-14 17:13 ` [Qemu-devel] [PATCH] linux-user/signal.c: Fix several issues for target alpha Richard Henderson @ 2015-09-14 18:35 ` Chen Gang 0 siblings, 0 replies; 2+ messages in thread From: Chen Gang @ 2015-09-14 18:35 UTC (permalink / raw) To: Richard Henderson, gang.chen.5i5j, riku.voipio, peter.maydell; +Cc: qemu-devel On 9/15/15 01:13, Richard Henderson wrote: > On 09/12/2015 08:15 PM, gang.chen.5i5j@gmail.com wrote: >> env->ir[IR_RA] = r26; >> env->ir[IR_PV] = env->pc = ka->_sa_handler; >> env->ir[IR_A0] = sig; >> env->ir[IR_A1] = 0; >> env->ir[IR_A2] = frame_addr + offsetof(struct target_sigframe, sc); >> env->ir[IR_SP] = frame_addr; >> + >> +give_sigsegv: >> + if (sig == TARGET_SIGSEGV) { >> + ka->_sa_handler = TARGET_SIG_DFL; >> + } >> + force_sig(TARGET_SIGSEGV); >> } > > Fallthrough into the sigsegv handler? > That's clearly wrong. > OK, thanks. Need add "return" before "give_sigsegv". I shall send patch v2 for it. Thanks. -- Chen Gang (陈刚) Open, share, and attitude like air, water, and life which God blessed ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-14 18:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1442114116-6146-1-git-send-email-gang.chen.5i5j@gmail.com>
2015-09-14 17:13 ` [Qemu-devel] [PATCH] linux-user/signal.c: Fix several issues for target alpha Richard Henderson
2015-09-14 18:35 ` Chen Gang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).