From: John Snow <jsnow@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com,
armbru@redhat.com, qemu-devel@nongnu.org, ppandit@redhat.com,
luodalongde@gmail.com, liuling-it@360.cn
Subject: Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions
Date: Mon, 14 Sep 2015 14:49:51 -0400 [thread overview]
Message-ID: <55F716CF.4050306@redhat.com> (raw)
In-Reply-To: <55F71564.1010906@msgid.tls.msk.ru>
On 09/14/2015 02:43 PM, Michael Tokarev wrote:
> 14.09.2015 21:04, John Snow wrote:
>> On 09/11/2015 02:56 AM, Michael Tokarev wrote:
>>> 09.09.2015 19:28, John Snow wrote:
>>>> We're a little too lenient with what we'll let an ATAPI drive handle.
>>>> Clamp down on the IDE command execution table to remove CD_OK permissions
>>>> from commands that are not and have never been ATAPI commands.
>>>
>>> FWIW, this issue has been assigned CVE-2015-6855 identifier, which
>>> can be reflected in the commit message when applying. Since this
>>> issue has security impact, it might be a good idea to add
>>>
>>> Cc: qemu-stable@nongnu.org
>>
>> I'm still awaiting review/acks, but would you like me to re-send this
>> patch to trivial, or just fwd/reply-to?
>
> I think it is anything but trivial ;) Well, the semantics is trivial,
> but it isn't -trivial material per se.
>
> I suggested add a Cc to qemu-stable, this can be done at commit,
> together with mentioning the CVE# assigned meanwhile, and I don't
> know who will commit it, Kevin?
>
> Thanks,
>
> /mjt
>
I'll be sending the pullreq through my tree, but I was waiting on at
least an ACK or so before I went ahead.
I can add CC: qemu-stable to the patch on-pull if that's sufficient for you.
--js
next prev parent reply other threads:[~2015-09-14 18:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 16:28 [Qemu-devel] [PATCH] ide: fix ATAPI command permissions John Snow
2015-09-11 6:56 ` Michael Tokarev
2015-09-14 18:04 ` John Snow
2015-09-14 18:43 ` Michael Tokarev
2015-09-14 18:49 ` John Snow [this message]
2015-09-15 8:26 ` Kevin Wolf
2015-09-15 6:53 ` Markus Armbruster
2015-09-15 16:42 ` John Snow
2015-09-15 18:11 ` Markus Armbruster
2015-09-15 18:22 ` John Snow
2015-09-15 18:50 ` Markus Armbruster
2015-09-15 19:12 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F716CF.4050306@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=liuling-it@360.cn \
--cc=luodalongde@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=ppandit@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).