From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [RFC PATCH 1/2] target-ppc: remove hreg_compute_mem_idx() from cpu_post_load
Date: Tue, 15 Sep 2015 09:25:52 +1000 [thread overview]
Message-ID: <55F75780.3010207@ozlabs.ru> (raw)
In-Reply-To: <1442259039-22137-2-git-send-email-mark.cave-ayland@ilande.co.uk>
On 09/15/2015 05:30 AM, Mark Cave-Ayland wrote:
> hreg_compute_mem_idx() has already been called previously by ppc_store_msr()
> via hreg_store_msr() and hreg_compute_hflags(). Drop the duplicate function
> call as it is no longer needed.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> target-ppc/machine.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target-ppc/machine.c b/target-ppc/machine.c
> index f4ac761..bd99844 100644
> --- a/target-ppc/machine.c
> +++ b/target-ppc/machine.c
> @@ -197,8 +197,6 @@ static int cpu_post_load(void *opaque, int version_id)
> env->msr ^= ~((1ULL << MSR_TGPR) | MSR_HVB);
> ppc_store_msr(env, msr);
>
> - hreg_compute_mem_idx(env);
> -
> return 0;
> }
>
>
--
Alexey
next prev parent reply other threads:[~2015-09-14 23:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 19:30 [Qemu-devel] [RFC PATCH 0/2] target-ppc migration fixes Mark Cave-Ayland
2015-09-14 19:30 ` [Qemu-devel] [RFC PATCH 1/2] target-ppc: remove hreg_compute_mem_idx() from cpu_post_load Mark Cave-Ayland
2015-09-14 23:25 ` Alexey Kardashevskiy [this message]
2015-09-14 19:30 ` [Qemu-devel] [RFC PATCH 2/2] target-ppc: add CPU IRQ state to PPC VMStateDescription Mark Cave-Ayland
2015-09-14 23:10 ` Alexey Kardashevskiy
2015-09-15 21:09 ` Mark Cave-Ayland
2015-09-17 4:32 ` Alexey Kardashevskiy
2015-09-20 20:31 ` [Qemu-devel] [RFC PATCH 0/2] target-ppc migration fixes Alexander Graf
2015-10-23 1:46 ` david
2015-10-23 19:22 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F75780.3010207@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=agraf@suse.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).