From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44241)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZbnyO-0007fs-Fc
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:00:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZbnyL-0007tw-Oa
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:00:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49227)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZbnyL-0007te-Ja
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:00:25 -0400
References: <alpine.DEB.2.02.1509081818590.2672@kaball.uk.xensource.com>
	<CAFEAcA80p5jaGYstmXYH204OExVUm2Mn=qfxC3FeibzPNDi7Tw@mail.gmail.com>
	<alpine.DEB.2.02.1509091248460.2672@kaball.uk.xensource.com>
	<alpine.DEB.2.02.1509091706120.2672@kaball.uk.xensource.com>
	<55F0DB30.6070607@intel.com>
	<CAFEAcA9RM0Q0ZrhgZxYqRdYb+GTsd7QyZtNJGKqxOYse8vShfA@mail.gmail.com>
	<55F14E20.6070805@intel.com>
	<alpine.DEB.2.02.1509101041540.2672@kaball.uk.xensource.com>
	<alpine.DEB.2.02.1509101122570.2672@kaball.uk.xensource.com>
	<55F69A18.20709@redhat.com>
	<alpine.DEB.2.02.1509151053410.2672@kaball.uk.xensource.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55F7FA43.40600@redhat.com>
Date: Tue, 15 Sep 2015 13:00:19 +0200
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1509151053410.2672@kaball.uk.xensource.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Chen,
	Tiejun" <tiejun.chen@intel.com>, "xen-devel@lists.xensource.com Devel" <xen-devel@lists.xensource.com>, QEMU Developers <qemu-devel@nongnu.org>, mst@redhat.com



On 15/09/2015 11:55, Stefano Stabellini wrote:
> On Mon, 14 Sep 2015, Paolo Bonzini wrote:
>> > On 10/09/2015 12:29, Stefano Stabellini wrote:
>>> > > +    if (lseek(config_fd, pos, SEEK_SET) != pos) {
>>> > > +        return -errno;
>>> > > +    }
>>> > >      do {
>>> > > -        rc = pread(config_fd, (uint8_t *)&val, len, pos);
>>> > > +        rc = read(config_fd, (uint8_t *)&val, len);
>>> > >      } while (rc < 0 && (errno == EINTR || errno == EAGAIN));
>> > 
>> > This leaks config_fd.
> I don't follow, it leaks config_fd where?

Where lseek returns -errno (and IIRC in other places in the same function).

Paolo