From: Paolo Bonzini <pbonzini@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: mdroth@linux.vnet.ibm.com, Alexey Kardashevskiy <aik@ozlabs.ru>,
agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
bharata@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector
Date: Tue, 15 Sep 2015 13:05:16 +0200 [thread overview]
Message-ID: <55F7FB6C.3010008@redhat.com> (raw)
In-Reply-To: <20150915003036.GR2547@voom.fritz.box>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 15/09/2015 02:30, David Gibson wrote:
>>> I think the comment is wrong or at least inaccurate; it only
>>> applies to the external QOM interface. The patch is a good
>>> idea, even though OBJECT(x)->y traditionally is not used
>>> (instead you assign OBJECT(x) to a different Object*
>>> variable).
> Ok.. so are you prepared to give a Reviewed-by, or do I need to
> ask someone else (Andreas?) to approve this as QOMishly correct?
I am, but as I said in another message I wonder if accessing the
parent field is actually necessary.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJV9/toAAoJEL/70l94x66DlgIH/3gVH53/bBLzUc77IfDbGlMZ
FIA94/uVb+HJWz29y0yv3V9RO+PpjhO9rQWUM3K+1TyH+Bu0st9HlGcxjhZVXpsH
So0IcVgBGFZry+3XyuIZ9TanpDcKo1cXSc5OZ/P7eBP/TviLcKshtfmn9WpgRWm7
DnVBFe1rSId7a8qn8BUeHyHtCLEwWcn8sOJla4w66PiGXVBG1p+mMU+lOXm6mQMD
sy3LNMRS2duhDyMncMF6tsTn03CesfiW+2b1U5U/Q3ZIFTLdOLFMTiBK8giTfd2J
FoePn1sZkF5SW4fPL8Gye1qbmnkpLUDMODHTUF3AI61Q11CAULFjxOkPK/QGEEI=
=lh5f
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-09-15 11:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 1:41 [Qemu-devel] [RFCv2 0/2] spapr: Cleanups to dynamic reconfiguration mechanism David Gibson
2015-09-14 1:41 ` [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector David Gibson
2015-09-14 6:23 ` Bharata B Rao
2015-09-14 8:22 ` Alexey Kardashevskiy
2015-09-14 11:45 ` David Gibson
2015-09-14 12:11 ` Paolo Bonzini
2015-09-14 14:06 ` Alexey Kardashevskiy
2015-09-14 14:24 ` Paolo Bonzini
2015-09-16 3:16 ` David Gibson
2015-09-17 15:50 ` Michael Roth
2015-09-17 15:53 ` Paolo Bonzini
2015-09-17 23:03 ` Michael Roth
2015-09-17 15:01 ` Michael Roth
2015-09-15 0:31 ` David Gibson
2015-09-15 0:30 ` David Gibson
2015-09-15 11:05 ` Paolo Bonzini [this message]
2015-09-14 1:41 ` [Qemu-devel] [RFCv2 2/2] spapr: Don't use QOM [*] syntax for DR connectors David Gibson
2015-09-14 4:07 ` Bharata B Rao
2015-09-14 4:14 ` David Gibson
2015-09-14 4:41 ` Bharata B Rao
2015-09-14 5:20 ` David Gibson
2015-09-14 8:13 ` Alexey Kardashevskiy
2015-09-15 4:03 ` Michael Roth
2015-09-15 4:21 ` Michael Roth
2015-09-16 3:18 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F7FB6C.3010008@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).