From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbqLM-0002dl-Jh for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:32:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbqLI-0001UR-94 for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:32:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbqLI-0001UN-3x for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:32:16 -0400 References: <1441905361-31967-21-git-send-email-stefano.stabellini@eu.citrix.com> <55F69ADF.40404@redhat.com> <20150915132531.GC9134@l.oracle.com> From: Paolo Bonzini Message-ID: <55F81DD2.3050304@redhat.com> Date: Tue, 15 Sep 2015 15:32:02 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini , Konrad Rzeszutek Wilk Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, qemu-devel@nongnu.org On 15/09/2015 15:28, Stefano Stabellini wrote: > >> > 2). Send an follow up patch to change this to abort()? (and wherever else I used >> > assert(..)? > Yes, that would be good. > > >> > 3). Wait till Paolo is done going through the patchset and then revisit 1) or 2)? > I don't know if Paolo has any more comments. No, the few comments I had were only prompted by Coverity. Paolo