Re: [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

On 09/15/2015 04:52 AM, Daniel P. Berrange wrote:
> On Mon, Sep 14, 2015 at 07:57:44PM +0200, Markus Armbruster wrote:
>> Generate just 'FOO' instead of 'struct FOO' when possible.
>>
>> Drop helper functions that are now unused.
>>
>> Make pep8 and pylint reasonably happy.
>>
>> Rename generate_FOO() functions to gen_FOO() for consistency.
>>
>> Use more consistent and sensible variable names.
>>
>> Consistently use c_ for mapping keys when their value is a C
>> identifier or type.
>>
>> Simplify gen_enum() and gen_visit_union()
>>
>> Consistently use single quotes for C text string literals.
> 
> I would have preferred to see one type of change per
> patch  to make review easier, but this has been through
> enough iterations now that no point changing again.

I made the same comment back on v3 or v4, and the conclusion from then
still holds now - it was less churn to take it as is (since we have
clients waiting on the patch to get in) than to worry about splitting
and reviewing that the split is sane.  :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]