From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbrcn-00078j-60 for qemu-devel@nongnu.org; Tue, 15 Sep 2015 10:54:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbrci-0001kM-Pz for qemu-devel@nongnu.org; Tue, 15 Sep 2015 10:54:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbrci-0001k6-LI for qemu-devel@nongnu.org; Tue, 15 Sep 2015 10:54:20 -0400 References: <1308b58bb2b2d1a7f4d3f484ea4ed8d8697bb010.1441627176.git.DirtY.iCE.hu@gmail.com> From: Eric Blake Message-ID: <55F83116.9090408@redhat.com> Date: Tue, 15 Sep 2015 08:54:14 -0600 MIME-Version: 1.0 In-Reply-To: <1308b58bb2b2d1a7f4d3f484ea4ed8d8697bb010.1441627176.git.DirtY.iCE.hu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8fGEekQrpRgUek8RHJ09eclnOFD1jkPj0" Subject: Re: [Qemu-devel] [PATCH 3/7] net: remove NetLegacy struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= , qemu-devel@nongnu.org Cc: Jason Wang , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8fGEekQrpRgUek8RHJ09eclnOFD1jkPj0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/07/2015 06:08 AM, K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n wrote: > NetLegacy is just Netdev with some extra fields (name, vlan) and an > optional id. This patch merges the two structs, and net_client_init1 > got some extra checks to make sure only accept valid -netdev command > lines. This is some extra work, but allows us to uniformly manage both= > legacy -net and non-legacy -netdev in code. >=20 > Signed-off-by: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n > --- > net/net.c | 42 +++++++++++++++++++++--------------------- > qapi-schema.json | 30 +++++++++--------------------- > 2 files changed, 30 insertions(+), 42 deletions(-) I'm still not a fan of this one. See my counter-proposal that rewrites patches 4/7 and 5/7 of this series to keep NetdevLegacy a separate type for command line usage, while exposing only Netdev through QMP (in particular, patch 2/29 and 27/29 are my rewrites, and 29/29 turns on Netdev use in QMP) https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg02580.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8fGEekQrpRgUek8RHJ09eclnOFD1jkPj0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+DEWAAoJEKeha0olJ0NqQUkIAJLUnPpWBMy6OQ48BnROSSUS aWR5zsAWMdsYcHcnoEL860YKHhlTVSQOnXfVl0tf3QEfoTANvLP50nqA0HHFuMpX JJILu8uYbg7iZOtGnFBCHM17QQAAlup5j2VvugKeQJBuxmbheuic6wAHIUMN8P/k SrekScjZhQg18yh9biKSFNqYFvvx++2XApim4Hwl9XSonlkg6H/whLp4WGek5qsQ rsL//Py5TZ8cdLn+MVoERAvlnZJB8XeTRWlcFEnz9SWvcFxYmEEAHzEG4SGuX2eV ThAOglWDX5cVfC+3E/Hn5yM8l9kL+MxJvGyqCtT/fOvev739UhB/G44ihUX5rV0= =pmYI -----END PGP SIGNATURE----- --8fGEekQrpRgUek8RHJ09eclnOFD1jkPj0--