From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbsHb-0001fO-2I for qemu-devel@nongnu.org; Tue, 15 Sep 2015 11:36:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbsHW-0005ZV-Mh for qemu-devel@nongnu.org; Tue, 15 Sep 2015 11:36:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbsHW-0005ZP-HS for qemu-devel@nongnu.org; Tue, 15 Sep 2015 11:36:30 -0400 References: <1441471439-6157-1-git-send-email-vsementsov@virtuozzo.com> <1441471439-6157-2-git-send-email-vsementsov@virtuozzo.com> From: Eric Blake Message-ID: <55F83AFC.8040905@redhat.com> Date: Tue, 15 Sep 2015 09:36:28 -0600 MIME-Version: 1.0 In-Reply-To: <1441471439-6157-2-git-send-email-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QkrnFjnJWWMCaBtFmHoVPoTBOUtsLM2vd" Subject: Re: [Qemu-devel] [PATCH 01/17] block: fix bdrv_dirty_bitmap_granularity() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QkrnFjnJWWMCaBtFmHoVPoTBOUtsLM2vd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/05/2015 10:43 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- The commit message summary mentions a one-line "what" (good), but is lacking a body that says "why" (that is, what was broken that needed fixing?) > block.c | 2 +- > include/block/block.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 It looks like all the patch does is make the signature const-correct, since querying the granularity does not modify the bitmap. So the commit message should say that. With an improved commit message, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QkrnFjnJWWMCaBtFmHoVPoTBOUtsLM2vd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+Dr8AAoJEKeha0olJ0NqCqsIAI2+VKxcxK+FoRxfTIEpdpvZ krKR5jAF3UmTMlcy1vlnIdgxkQqvHIMPkBef15lVLSChp0wSYVANTpeIi2nJSfOu L20qeo1m7AK9wvwyBKROqAuhCCUVy9ppNu7UHtH3d8qce7rG41mkZLul94RhGSNS Pcn6lEJDzskvNwOHye4z9QFz7T5FfbsZfA7UliUg+WS39JYhkq4acl2Ag5tdjHA6 lhA5NCwIR2qtpKOrKSGionK1DiX+5D6g7kLThmyCws9tN2pyMztnJY0Udyri+oBE aGbaB8DO0eqF54/V0uns3/N9sifHVn81pLKwLEc0vOUGirCqolpGlxPODyOuRKU= =SPRz -----END PGP SIGNATURE----- --QkrnFjnJWWMCaBtFmHoVPoTBOUtsLM2vd--